unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tadeus Prastowo <tadeus.prastowo@unitn.it>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Do you really mean to call `cl--generic-prefill-dispatchers' twice?
Date: Thu, 4 Apr 2019 00:45:24 +0200	[thread overview]
Message-ID: <CAN-HRFZPZ47=sJQfXKJGzUx=jFVUODuGLsA0PP2-+WE2Va9wHQ@mail.gmail.com> (raw)

Hi Stefan,

While looking at the diff of commit
cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk:
-- 8< ----------------------
@@ -1205,6 +1209,7 @@ See the full list and their hierarchy in
`cl--generic-typeof-types'."
    (cl-call-next-method)))

 (cl--generic-prefill-dispatchers 0 integer)
+(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer)

 ;;; Dispatch on major mode.

-- 8< ----------------------

Why didn't you delete the first call `(cl--generic-prefill-dispatchers
0 integer)'?

Thanks.

-- 
Best regards,
Tadeus



             reply	other threads:[~2019-04-03 22:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 22:45 Tadeus Prastowo [this message]
2019-04-04 16:04 ` Do you really mean to call `cl--generic-prefill-dispatchers' twice? Stefan Monnier
2019-04-04 17:14   ` Tadeus Prastowo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN-HRFZPZ47=sJQfXKJGzUx=jFVUODuGLsA0PP2-+WE2Va9wHQ@mail.gmail.com' \
    --to=tadeus.prastowo@unitn.it \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).