From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tadeus Prastowo Newsgroups: gmane.emacs.devel Subject: Re: Untested patch for trivial memory leak in update-game-score.c Date: Wed, 1 May 2019 17:11:40 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="248330"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Adam Richter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 17:12:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLquB-0012Q5-L8 for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 17:12:19 +0200 Original-Received: from localhost ([127.0.0.1]:60753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLquA-0006Wl-LD for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 11:12:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLqu2-0006Va-Pq for emacs-devel@gnu.org; Wed, 01 May 2019 11:12:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLqtu-00080T-F8 for emacs-devel@gnu.org; Wed, 01 May 2019 11:12:07 -0400 Original-Received: from mail-it1-x133.google.com ([2607:f8b0:4864:20::133]:52081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLqts-0007wz-Qt for emacs-devel@gnu.org; Wed, 01 May 2019 11:12:01 -0400 Original-Received: by mail-it1-x133.google.com with SMTP id s3so10217898itk.1 for ; Wed, 01 May 2019 08:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn.it; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GfPkIFq0LkX2HM/Jb4f3eJPQYnLlenwxM+AAYelpIIA=; b=HCwi12L7fHQjpuwZay76sNXD0rclDwwnmyiX0EZTT+POXov1+X10mUjZAhNCFaURD3 oXcpzH8kj/BRqWHN1y2ZLyDuHXUsuoPBoBsZtNG7b1JfXiKCj9AzcaE05hRfw9ZUaqMf S8LhWes4jehsE/KIFhSkeF/OhFkjf8Vrl4rYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GfPkIFq0LkX2HM/Jb4f3eJPQYnLlenwxM+AAYelpIIA=; b=K2yR3oBeufM8L0GA4+Gw4kE3o4iktLscwz44isbaxz9DAYyzA17Pl+lbXwY4gB8Axc 2ulO2H98Rz+5qGgw7a2AgG1Oot1MDC5HQtTLoGjud6/frPo3+/MV1Tac0bTAa3sNjp8h D0SGINfDnkV5SatfpXbUbCXZdikca/sp/fBR2j4MpKAtvYPfnV6Rgc5LF6wImO/LZv3D BIar81nbGwte2EcZ27+juQLpcVOp5BD7sXJQzYdL9Q8dmYDHYb2DIJjV0sjIOosA8q0J bj9GECSbZUnsf0wbGNubbeXja0S6urhYIe2BCklUdDKxlyGAVqPrdXhnreWklqvZd3r3 Bs3g== X-Gm-Message-State: APjAAAX4Ei2jtGgnf4zay+5nNI+xZhVYUDs4ZxodOe3w7EQHDyCXnxzr wm9h4Z+EZr+VNB/sUzjkxXftExeS656GAsB/wr5/ X-Google-Smtp-Source: APXvYqygSuEWWCxS4A+RTOfXiivT7iuSL9+FYVIgwmpKFml6k8/jsOpqmjCm5ttNJFNC+Viw45iWsOHc7a1HxTUnBjI= X-Received: by 2002:a24:a505:: with SMTP id k5mr3811719itf.160.1556723511348; Wed, 01 May 2019 08:11:51 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::133 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236091 Archived-At: On Tue, Apr 30, 2019 at 11:22 PM Adam Richter wrote: > As far as I can tell, update-game-score.c is not compiled when I build > emacs, Use the configure flag --with-gameuser, quoting http://www.gnu.org/software/emacs/news/NEWS.26.1: ** The configure option '--with-gameuser' now defaults to 'no', as this appears to be the most common configuration in practice. When it is 'no', the shared game directory and the auxiliary program update-game-score are no longer needed and are not installed. But, without that configure flag, you will hit this bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35056 > Adam -- Best regards, Tadeus