From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Wed, 24 Apr 2013 22:52:03 -0400 Message-ID: References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1366858355 13532 80.91.229.3 (25 Apr 2013 02:52:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Apr 2013 02:52:35 +0000 (UTC) Cc: Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 25 04:52:39 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UVCIR-0005Gx-LK for ged-emacs-devel@m.gmane.org; Thu, 25 Apr 2013 04:52:31 +0200 Original-Received: from localhost ([::1]:46614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVCIR-0008Vd-B9 for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2013 22:52:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVCIN-0008TL-Ch for emacs-devel@gnu.org; Wed, 24 Apr 2013 22:52:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVCIM-0005NG-7D for emacs-devel@gnu.org; Wed, 24 Apr 2013 22:52:27 -0400 Original-Received: from mail-ia0-x231.google.com ([2607:f8b0:4001:c02::231]:38797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVCIL-0005N2-VJ for emacs-devel@gnu.org; Wed, 24 Apr 2013 22:52:26 -0400 Original-Received: by mail-ia0-f177.google.com with SMTP id y26so2284563iab.22 for ; Wed, 24 Apr 2013 19:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=fYBG9M+Pmg2v1WYcG0xg+AKi9r9vHATMZxANsRB+S5Y=; b=G1dyE/tZDnmTgqjOTTif0CyFkUVUlSDI4hNMfmBUUVliOyTT9W1pwMHS6U6pcbfAFF hlJhMEzed+qWIc+qYFD3tszkPU9xC8SfgsEw7OT6Hb7Sr31YmWeroVBBQwawYObyAfzo zXDeO/acguIw0A2PnVq15ewvz81k+rW8tiWTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=fYBG9M+Pmg2v1WYcG0xg+AKi9r9vHATMZxANsRB+S5Y=; b=YrbEM3SSuEoVw5A7DBcrhi6ed0YbRsWX83i/NgCD+5/k6SVHKn8uFi0l88JIAulz3B tcJafZayLvmx7A5v5NR5njhT9VRm58hzeGosRKHu0zeHv//1d9azpH1VcbHeXDOA4a/U T+Z4jBQOPO9RRJpcg1WWLCXZigOnDBbv+DeNjtDEgLkITyNbqC2h1mWF3xpOibPwxwqK 0/FupXbDTULzTQa7T33PUq8YqPvHRMx4ZcOJzcbpaQD2sLeym/TOlc8K57+Ixq4sYyOc 7cvjflF7RBP9AkQVSgmJYHgYjxM2vNNSBgyvrcYoNBQKJM/uC4/yqu51rz2jhZEehwpW Jd9Q== X-Received: by 10.50.57.200 with SMTP id k8mr30024221igq.44.1366858344968; Wed, 24 Apr 2013 19:52:24 -0700 (PDT) Original-Received: by 10.64.92.165 with HTTP; Wed, 24 Apr 2013 19:52:03 -0700 (PDT) In-Reply-To: X-Gm-Message-State: ALoCoQmgEZldklAqXBgzcE/BgE1yWqSRxVI8fp6Z9dXN60vnAT/Gd4aY0XvZETPb4ibi1gf2lLX+ X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c02::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159162 Archived-At: I forgot to respond on-list. Here's what I said: Stefan Monnier wrote: > I'd like to move forward on this but haven't heard from you about the > comments below. I just now realize that I only sent it to emacs-devel, > so maybe you just didn't see it. Sorry, I haven't had much time to work on this recently. I'll try to get some done now. >>>>>> "Stefan" == Stefan Monnier writes: > >>> In the end it should be a single commit to the Bazaar repo, and there's >>> no reason to break it up for your audience here. Agreed. >> I've been looking at the patch, trying to understand what it does, and >> I think I'd first really need to see a good description of what it does, >> because obviously it doesn't just switch to using a defstruct. It also >> does things like renaming functions and various minor refactorings that >> don't seem directly related (they don't necessarily seem bad either, >> but I wasn't able to understand all of what's going on from just >> looking at the patch). I'll do a better job of explaining the whole patch. Should I include that in some sort of file in the repo or just on the mailing list? Would a detailed-ish explanation of the changes and rationale be appropriate for the ChangeLog or NEWS files? >> I did notice that package-desc-from-define uses ignore-errors where the >> previous code did not. `ignore-errors' can be handy, but it should be >> used with restraint because it too easily hides problems. Since the >> previous code didn't use them, I don't see why we'd need them now. I forget why I did this. I'll look into it now. I also remembered that I haven't touched package-x.el. This would be kind of important. I'll write tests for it as well. About package-x.el, is the HTML and RSS updating functionality actually used? Currently, the only way to access the functionality is calling `package-maint-add-news-item' or the non-interactive `package-upload-buffer-internal' directly. GNU ELPA clearly doesn't use the version in package-x.el, as the HTML generated is not what package-x produces. Can I consider it unused and delete it? If not, I'll refactor it with the rest of the code. -- Daniel Hackney