From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Tue, 25 Jun 2013 17:49:15 -0400 Message-ID: References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> <87k3lnvr7c.fsf@yandex.ru> <51C8D889.5000404@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1372196993 14025 80.91.229.3 (25 Jun 2013 21:49:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Jun 2013 21:49:53 +0000 (UTC) Cc: Stefan Monnier , Emacs development discussions To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 23:49:55 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Urb7a-0000qM-9n for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 23:49:54 +0200 Original-Received: from localhost ([::1]:40470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urb7a-0000Sn-0R for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 17:49:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urb7K-00006g-Aa for emacs-devel@gnu.org; Tue, 25 Jun 2013 17:49:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Urb7J-0004Yz-8z for emacs-devel@gnu.org; Tue, 25 Jun 2013 17:49:38 -0400 Original-Received: from mail-ie0-x231.google.com ([2607:f8b0:4001:c03::231]:42170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urb7J-0004Yp-1C for emacs-devel@gnu.org; Tue, 25 Jun 2013 17:49:37 -0400 Original-Received: by mail-ie0-f177.google.com with SMTP id aq17so27297860iec.8 for ; Tue, 25 Jun 2013 14:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=6+FSu8EPk8h+HzE+q53IkfVuQMJf4rKvVmOhocMlSRk=; b=RjqX9BxQwprdjAcOz9b/Ai6qHRh9EBvgGBpNEpoNL9Qfy28i7DKJyZtuwGthVrDJdE ePKWudW5fQeo0rOzL5vTtjHLQiOT6u/oJkiwKcXhTGY2uq/zW+2NmxzbFyYy2OhRBEFd xajp1azdz6LPW4OuaG6vuRY5Tzr5E9cEtI2go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=6+FSu8EPk8h+HzE+q53IkfVuQMJf4rKvVmOhocMlSRk=; b=ZijxLnBzzJOwDqIqES8A8s6YMRyUNR0ukiqh+O0Ud1AzUHFWkSGT7wXpJBsLWfOXJf h6+eUNy4boVaxx+HRJIcemxLqugvxyPFE71ajn7In2DvDGix9BcNXgVOEPoTVyFCBY5r lXACBK+Hh4p2eRTak+7/28PMK7lwTRynwnip7plhudKRAkuPhe/qBTMFcQIKPqfS36mT ymjuxZADwQnlsLFL1Um4B3rfUPWprGtk2/ERSFIb2pwCzPorbT5l7rgxyDhdo2oC2xt4 bBxtCyOsoVsjhYCj1fsP1Ft56VKxtZJYkPWh8Bb5wZ/QMHUuExxPRIxtPmfWfxQ0q2VN sWHQ== X-Received: by 10.43.159.73 with SMTP id lx9mr538898icc.59.1372196975915; Tue, 25 Jun 2013 14:49:35 -0700 (PDT) Original-Received: by 10.64.141.49 with HTTP; Tue, 25 Jun 2013 14:49:15 -0700 (PDT) In-Reply-To: <51C8D889.5000404@yandex.ru> X-Gm-Message-State: ALoCoQm/aaa6+KGv0ftofwgGjeSnD0Aw3FJPhqSC7TigmoYRCd3yLMe8K226DtWoqm0x2VOx1Hav X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161059 Archived-At: Dmitry Gutov wrote: > Just an update, I've tried to bring the tests over today, but they're quite > dependent on the implementation. > > I still have 6/10 failures, so far. That's odd. Make sure you remove "finder-inf.el{,c}" and re-make. Its format has changed and it needs to be re-generated. > Daniel: > > One thing I definitely didn't like is the usage of raw cl-struct vectors as > reference values to compare against. These are implementation details of > cl-defstruct, and we have no business setting them in stone in a test suite > for code that just uses defstruct. Good point. The raw vectors should be replaced with calls to `package-desc-create' with the appropriate arguments. > Relying on an external program (ginstall-info) is also not nice, for the > usual alternative-OS-related reasons. My rationale behind that was to have the multi-file package be in "source form": all the files in the repo would be actual user-created source files, and not generated files of any kind. That is probably not necessary for testing, so the multi-file package directory could be replaced with a single .tar. This means that all of the package-building functions (and parts of `with-package-test') could be removed as well. -- Daniel Hackney