From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] package.el: Kill "PKGNAME-autoloads.el" buffer Date: Sun, 28 Oct 2012 13:45:50 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1351446375 12119 80.91.229.3 (28 Oct 2012 17:46:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2012 17:46:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 28 18:46:24 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TSWwJ-0004bV-84 for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2012 18:46:23 +0100 Original-Received: from localhost ([::1]:36776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSWwB-0002Uo-3Y for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2012 13:46:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSWw8-0002UX-N7 for emacs-devel@gnu.org; Sun, 28 Oct 2012 13:46:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSWw7-0003fY-NG for emacs-devel@gnu.org; Sun, 28 Oct 2012 13:46:12 -0400 Original-Received: from mail-ia0-f169.google.com ([209.85.210.169]:51191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSWw7-0003fK-G9 for emacs-devel@gnu.org; Sun, 28 Oct 2012 13:46:11 -0400 Original-Received: by mail-ia0-f169.google.com with SMTP id h37so4195152iak.0 for ; Sun, 28 Oct 2012 10:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=+I4y2Jm8/Lunfg3RyuwjZkqX6LyYRRtHT6RtsveTe2s=; b=RbdKlwZdluY4K7Zyz8+Vxa/9ZuUq+G1Qxq4BGY2oGIqu3xmvtUl1t9n5pWHtp1PS5q MpX9LyX4r4drsq17yoKlzLGUC3cYyjdzfwlbYu/D9EMSDzAiENXAVKi/ZesWy6L8dpby 34jB3/BYVHU3c/6id0kbbyBkSCb8aluCzWN4U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=+I4y2Jm8/Lunfg3RyuwjZkqX6LyYRRtHT6RtsveTe2s=; b=VClN7tbcQIb4+gDX2QpbboITAJKXvehuVqdfJU3RXCu4HuPnvYqE28R6otalhBJGaR OWkHBAM6FnIyMpKM+tA4wL3709mu9KVSgg3wD9/BPwt8SkERNNs2xpQMMwcELaEn6dLR K3KNrA18LICnEsxBmRfs2rT0ooK1PvAbha4X2IymaBbqqnBRaAmgaildpu6L05mb9MQb 5eBFjQEYkl8q1UZ4q7FpsRgfFHO8h3UVhk+htBPTAQzZXQrYc5pyybtrtdWMLTsdRP0h FAIUaS2L4xFmzFjpAOJRvV5lXdbIWhjaX4YK+qG4qe2uZ5RoesKYVi8Ui9M7aeiLDvk7 BgEg== Original-Received: by 10.43.98.68 with SMTP id cn4mr23211790icc.14.1351446370287; Sun, 28 Oct 2012 10:46:10 -0700 (PDT) Original-Received: by 10.64.0.110 with HTTP; Sun, 28 Oct 2012 10:45:50 -0700 (PDT) In-Reply-To: X-Gm-Message-State: ALoCoQnSPQEogRDlqdGK85zFARHBdKPb4k/W0R1wlg51gZJI++VaafKD01nrm90lhyRzXhJzECkJ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154556 Archived-At: Whoops! I should be a bit more careful about killing the right buffer. Use this patch instead: diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 8122b16..ddff5ab 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,11 @@ +2012-10-28 Daniel Hackney + + * emacs-lisp/package.el (package-generate-autoloads): Kill buffer + "PKGNAME-autoloads.el". This prevents the buffers from sticking + around after a package installation. If the package is updated or + deleted, the left-over buffer can interrupt the automated flow of + things. + 2012-10-27 Eli Zaretskii * profiler.el (profiler-report-make-entry-part): Fix help-echo diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 303642b..636a477 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -587,10 +587,13 @@ EXTRA-PROPERTIES is currently unused." (let* ((auto-name (concat name "-autoloads.el")) ;;(ignore-name (concat name "-pkg.el")) (generated-autoload-file (expand-file-name auto-name pkg-dir)) - (version-control 'never)) + (version-control 'never) + buf) (unless (fboundp 'autoload-ensure-default-file) (package-autoload-ensure-default-file generated-autoload-file)) - (update-directory-autoloads pkg-dir))) + (update-directory-autoloads pkg-dir) + (when (setq buf (find-buffer-visiting generated-autoload-file)) + (kill-buffer buf)))) (defvar tar-parse-info) (declare-function tar-untar-buffer "tar-mode" ())