unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Hackney <dan@haxney.org>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] package.el: Kill "PKGNAME-autoloads.el" buffer
Date: Sun, 28 Oct 2012 13:45:50 -0400	[thread overview]
Message-ID: <CAMqXDZskAA=Dng0UQLog_bAV9J9iKraFY9iEtzxuVh+rTyazkA@mail.gmail.com> (raw)
In-Reply-To: <CAMqXDZuJU1ad3VCdGiDjJO-zhnRMSp=XG7VKNuXOhaccXMCUyQ@mail.gmail.com>

Whoops! I should be a bit more careful about killing the right buffer.
Use this patch instead:

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 8122b16..ddff5ab 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,11 @@
+2012-10-28  Daniel Hackney  <dan@haxney.org>
+
+        * emacs-lisp/package.el (package-generate-autoloads): Kill buffer
+        "PKGNAME-autoloads.el". This prevents the buffers from sticking
+        around after a package installation. If the package is updated or
+        deleted, the left-over buffer can interrupt the automated flow of
+        things.
+
 2012-10-27  Eli Zaretskii  <eliz@gnu.org>

        * profiler.el (profiler-report-make-entry-part): Fix help-echo
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 303642b..636a477 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -587,10 +587,13 @@ EXTRA-PROPERTIES is currently unused."
   (let* ((auto-name (concat name "-autoloads.el"))
         ;;(ignore-name (concat name "-pkg.el"))
         (generated-autoload-file (expand-file-name auto-name pkg-dir))
-        (version-control 'never))
+        (version-control 'never)
+        buf)
     (unless (fboundp 'autoload-ensure-default-file)
       (package-autoload-ensure-default-file generated-autoload-file))
-    (update-directory-autoloads pkg-dir)))
+    (update-directory-autoloads pkg-dir)
+    (when (setq buf (find-buffer-visiting generated-autoload-file))
+      (kill-buffer buf))))

 (defvar tar-parse-info)
 (declare-function tar-untar-buffer "tar-mode" ())



  reply	other threads:[~2012-10-28 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 17:11 [PATCH] package.el: Kill "PKGNAME-autoloads.el" buffer Daniel Hackney
2012-10-28 17:45 ` Daniel Hackney [this message]
2012-10-28 20:43   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMqXDZskAA=Dng0UQLog_bAV9J9iKraFY9iEtzxuVh+rTyazkA@mail.gmail.com' \
    --to=dan@haxney.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).