From: Le Wang <l26wang@gmail.com>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: emacs-devel@gnu.org
Subject: Re: fix for bug 10994 breaks ido customizations in major way
Date: Mon, 6 May 2013 23:11:35 +0800 [thread overview]
Message-ID: <CAM=K+iomHN_qsffQ3TXv0ZwnYzTMEXLfGaYpHPXtj6HE75pdQw@mail.gmail.com> (raw)
In-Reply-To: <87ip2xsb1r.fsf@wanadoo.es>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
On Sun, May 5, 2013 at 11:26 PM, Óscar Fuentes <ofv@wanadoo.es> wrote:
>
> However, the real issue being discussed here is if avoiding the overhead
> of delete-dups on ido-completing-read warrants breaking some extensions
> on a catastrophic way.
Upon further reflection, I realized that #10994 is only triggered by
runs of the same string.
I've attached a patch that removes runs without calling delete-dups.
Rough testing indicates it's fast. :)
--
Le
[-- Attachment #2: ido-remove-dups3.diff --]
[-- Type: application/octet-stream, Size: 1514 bytes --]
diff --git a/lisp/ido.el b/lisp/ido.el
index bedf00e..73ab39e 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -3159,8 +3159,7 @@ Use `eq' for comparison."
(sofar nil))
(while (not ret)
(setq next (car items))
- ;; Use `eq' to avoid bug http://debbugs.gnu.org/10994
- (if (eq next elem)
+ (if (equal next elem)
(setq ret (append items (nreverse sofar)))
;; else
(progn
@@ -3787,7 +3786,7 @@ This is to make them appear as if they were \"virtual buffers\"."
(if (string-match re name)
(setq matches (cons item matches)))))
items))
- matches))
+ (ido-delete-runs matches)))
(defun ido-set-matches ()
@@ -4678,6 +4677,25 @@ For details of keybindings, see `ido-find-file'."
ido-temp-list))))
(ido-to-end summaries)))
+
+(defun ido-delete-runs (list)
+ "Delete consecutive runs of same item in list.
+Comparison done with `equal'. Runs may loop back on to the first
+item, in which case, the ending items are deleted."
+ (let ((tail list)
+ before-last-run)
+ (while tail
+ (if (consp (cdr tail))
+ (if (equal (car tail) (cadr tail))
+ (setcdr tail (cddr tail))
+ (setq before-last-run tail)
+ (setq tail (cdr tail)))
+ (setq tail (cdr tail))))
+ (when (and before-last-run
+ (equal (car list) (cadr before-last-run)))
+ (setcdr before-last-run nil)))
+ list)
+
;;; Helper functions for other programs
(put 'dired-do-rename 'ido 'ignore)
next prev parent reply other threads:[~2013-05-06 15:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 17:57 fix for bug 10994 breaks ido customizations in major way Le Wang
2013-05-03 4:13 ` Leo Liu
2013-05-03 12:49 ` Le Wang
2013-05-03 20:33 ` Leo Liu
2013-05-04 7:00 ` Le Wang
2013-05-04 8:58 ` Óscar Fuentes
2013-05-04 13:00 ` Le Wang
2013-05-05 10:57 ` Óscar Fuentes
2013-05-05 11:39 ` Leo Liu
2013-05-05 12:20 ` Óscar Fuentes
2013-05-05 12:58 ` Leo Liu
2013-05-05 13:38 ` Óscar Fuentes
2013-05-05 14:31 ` Stephen J. Turnbull
2013-05-05 15:26 ` Óscar Fuentes
2013-05-06 15:11 ` Le Wang [this message]
2013-05-06 22:49 ` Vitalie Spinu
2013-05-07 1:01 ` Óscar Fuentes
2013-05-07 9:35 ` Le Wang
2013-05-07 10:26 ` Vitalie Spinu
2013-05-07 10:35 ` Óscar Fuentes
2013-05-07 14:49 ` Le Wang
2013-05-07 21:18 ` Stefan Monnier
2013-05-07 14:42 ` Le Wang
2013-05-07 14:44 ` Drew Adams
2013-05-07 14:47 ` Le Wang
2013-05-07 19:00 ` Vitalie Spinu
2013-05-07 19:53 ` Óscar Fuentes
2013-05-08 0:04 ` Leo Liu
2013-05-08 0:35 ` Le Wang
2013-05-08 3:10 ` Leo Liu
2013-05-08 3:29 ` Leo Liu
2013-05-08 4:49 ` Leo Liu
2013-05-08 8:14 ` Vitalie Spinu
2013-05-08 8:42 ` Leo Liu
2013-05-08 12:23 ` Le Wang
2013-05-08 14:29 ` Leo Liu
2013-05-08 20:56 ` Juri Linkov
2013-05-10 1:52 ` Leo Liu
2013-05-17 2:48 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=K+iomHN_qsffQ3TXv0ZwnYzTMEXLfGaYpHPXtj6HE75pdQw@mail.gmail.com' \
--to=l26wang@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).