From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.devel Subject: Re: built-in sqlite support in 29 - still time for changes? Date: Tue, 21 Mar 2023 10:02:34 -0400 Message-ID: References: <83fs9y6xbx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39598"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 15:03:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pecaO-000A4u-Qn for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 15:03:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pecZp-0004tb-9D; Tue, 21 Mar 2023 10:03:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pecZd-0004rw-Kq for emacs-devel@gnu.org; Tue, 21 Mar 2023 10:02:58 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pecZc-0002fA-3j; Tue, 21 Mar 2023 10:02:49 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id z10so8607349pgr.8; Tue, 21 Mar 2023 07:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679407365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PpZxR9HDfGf1ugWLvqTm05DDo87Rs/5eWdsuqnooQxg=; b=SaEmEQxq+qBx8SKW8IZOGdzoEYBKafGCDz8t6QV95hivbFjPtKEQYJPUwjQmr4VY8e NYFezIsfpmlqZMKm8cw4bkmZpt7ELJ9DqCvdgS1dfcfsNLWs4HbL7YBE6/erweqdr3Fr R9mSA/D2DcodIByGlj2OoUCCdt5YsNqxITuWjGWTmbYk1gWcoH1yXhdclEGB+AqwSFcB AQiBdHRHGlrErUmgGS8I86eVEKokKDcYVLI2BXpGRHzbQBcJ06qiEoyDdbnS5d2rKeXX XZ04HmmbbYOLJpXrx67c3c69gEJOvFXWhzEYwABybJxXneO2B7U/gDQtCvHxksjXzxq9 8zbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407365; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PpZxR9HDfGf1ugWLvqTm05DDo87Rs/5eWdsuqnooQxg=; b=OvVdOamuhpYFHLC6ox32UORAhf6yPjWq2jHtnlpjJ0dUHnXgM574KD0lthJ8Dq+o/c e734g8pRYFj3/oVCfWaSYVLuj1rDFNVYomcmb69dM49q7FdE1ZpOkxi/q8gER9/LKHKj 8IJccHepEj6lFT5sbK03PKER8vJamtAYYRM77ICLh1h5XKgxxH1ftA8UKpkypfpK0RrV sf1fBGtbDEZcZyBTEpuKqGJ+JIfJf6SamXfIBK/AfFzG/KuWwQrV7UBHonqPmi0VmZDH JIYrBSPgyKNKTNJ5IokrejSTAWw5yzJR9ZvXpkXDa7pIK4qTWaHJyfr1QqkwZx1FJYFF k++g== X-Gm-Message-State: AO0yUKV13JsPw/MqpqegCJjaistCSwuMTBPTkDmnqpxfKE/CfWG5qF4K DNz3ufg61JvCLaacyky15aonv7en7F/5Cf9ITaEezbvj X-Google-Smtp-Source: AK7set8vLkqt2mKHdsTg1mDUuJH2NfLjWOi9424lSlyUJS/21z6MXgcAYIrV8+BHGYgVV6A2COX0DTJR9UJSm6qi2vI= X-Received: by 2002:a63:f110:0:b0:503:91ff:8dd8 with SMTP id f16-20020a63f110000000b0050391ff8dd8mr684941pgi.4.1679407364817; Tue, 21 Mar 2023 07:02:44 -0700 (PDT) In-Reply-To: <83fs9y6xbx.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=owinebar@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304653 Archived-At: On Tue, Mar 21, 2023 at 9:35=E2=80=AFAM Eli Zaretskii wrote: > > From: Lynn Winebarger > > Date: Tue, 21 Mar 2023 09:18:16 -0400 > > > > * Is the current code mature enough to document properly, or is that > > being delayed until the implementation is more mature? > > I'm not sure I understand what do you mean by "document properly", > since the SQLite support is already documented in the ELisp reference > manual. That's user error on my part. Even though I was running my last built version of master, the last version of emacs I built/installed was 28.3, so I was seeing the old manual. Thanks > (I have no opinion on the other issues you raise.) Would patches still be accepted for emacs-29? I don't know what the cutoff is. For the first point in particular, I don't know if the emacsql convention is the best, but it seems gratuitous to change the idiom unless there's a good reason. It seems like emacsql query compiler could be adapted to the builtin support with the advantage of not being restricted to string values, so existing code could be conveniently ported. Lynn