From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.devel Subject: Re: Regression in dump-emacs-portable Date: Fri, 17 Feb 2023 07:57:46 -0500 Message-ID: References: <83ttzocomk.fsf@gnu.org> <834jrncd6a.fsf@gnu.org> <83o7pt395q.fsf@gnu.org> <87lekwooj0.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27232"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 17 13:58:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT0K6-0006xO-0Y for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Feb 2023 13:58:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pT0JP-0004gA-VM; Fri, 17 Feb 2023 07:58:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT0JO-0004fR-Dc for emacs-devel@gnu.org; Fri, 17 Feb 2023 07:58:02 -0500 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pT0JM-0001Xh-ON; Fri, 17 Feb 2023 07:58:02 -0500 Original-Received: by mail-pl1-x632.google.com with SMTP id j6so1416931plh.1; Fri, 17 Feb 2023 04:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=v+K2iMUxiJAesIn+vXr07YxtaE05mcRLUotjnTTVIsA=; b=Ap1LbuDD8JiZkTFdEEShFmexTJ6ghdOnsQK+h8yBeU8KgjAeYS+VYNDLqQMsViNEj+ 9JVhwmQnoNUafaUFApOrHRCkeGxEbhzCfWAB8HlanxQ8BTNEyzJB41ubIsX9R50J7JZW IwOdYIdDMvKolwgPJgRJEpPTOCsnkji+iPgST18K/V2OkmxkQR9mvWBsnWGxL/SCEEY3 TvdLArwPIyABAX4Q0ooINHpHcwZ1ahMVT1R1wdCbCUfWMatubgvPL4KJlA+wiFRL64Wx YVHzWHeiEF4yXx5S31Np6oLuaQoTafIachSiDpuEupiwbitgs9Qg/dK0NCDGOUD/Uhf7 5gNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v+K2iMUxiJAesIn+vXr07YxtaE05mcRLUotjnTTVIsA=; b=CZQl7/yetN0obuUJKZpmVyqUFsd+nW6+hHKdKeAy0GKuy5wXbErkhzysurSSjh5iFs wAJupYKfIFvrSaQDuSkcjhX37CpO3fzJP0bGaXzZSresapYLh8oHXzFmxhvbRMyWb/W4 /E+15MguXTpFR45XlLM5/zM8s/Y5NhQvNSCk0eLdvJQiOc/Vx+i4PsvlZbwe8sSPxjd/ kKTkNgreGNPKYpArmQp3WWlQyDA0aqCrDwIJ5XbF6roSQqwkN2hPKrV/XpCZsB1tUkDB C+/tgNWSnoojlWitJ5lns+uJXLYxFJyFKFcndHX6A+KZrftXvr1TfPFVAhCSOv/UAJWV rPPA== X-Gm-Message-State: AO0yUKXrDMiZO9y3eqIf7HCnnbOw31m0PHWti3udnInPK1+gNkDfdWAJ QdJrgXcC+Tszm+2aVfxixEaGLLF/VUbXDhBMGto= X-Google-Smtp-Source: AK7set85RaBjiGPl92wiR3qCJiTdVGzf9vDQMV7rIgptnSpQz0iYWBJSjId6GSNblO09ix6R9kssRb1BhvqsRLZNuXI= X-Received: by 2002:a17:90b:1bcf:b0:22c:4a69:6805 with SMTP id oa15-20020a17090b1bcf00b0022c4a696805mr1507360pjb.7.1676638678623; Fri, 17 Feb 2023 04:57:58 -0800 (PST) In-Reply-To: <87lekwooj0.fsf@yahoo.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=owinebar@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303473 Archived-At: On Fri, Feb 17, 2023 at 12:23 AM Po Lu wrote: > > Lynn Winebarger writes: > > > This seems to be related to whatever object "treesit-font-lock-rules" creates. > > The moral seems to be to create tests of each type of object a > > user-visible lisp function might create to get quick test cases. > > case PVEC_CONDVAR: > error_unsupported_dump_object (ctx, lv, "condvar"); > case PVEC_SQLITE: > error_unsupported_dump_object (ctx, lv, "sqlite"); > case PVEC_MODULE_FUNCTION: > error_unsupported_dump_object (ctx, lv, "module function"); > case PVEC_SYMBOL_WITH_POS: > error_unsupported_dump_object (ctx, lv, "symbol with pos"); > default: > > Please add the all the tree-sitter pvec types here, and see which one it > is. I just pretty-printed the value of the variable this sets instead: (pp sh-mode--treesit-settings (current-buffer)) ((# t comment nil) (# t function nil) (# t string nil) (# t heredoc nil) (# t variable nil) (# t keyword nil) (# t command nil) (# t declaration-command nil) (# t constant nil) (# t operator nil) (# t builtin-variable nil) (# t number nil) (# t bracket nil) (# t delimiter nil) (# t misc-punctuation nil)) I'm guessing it's whatever # represents. The core dump from pdumping an overlay is a bigger problem to me. Worst case, I can disable tree-sitter when running ./configure, which is not an option for overlays. Also, core dump from running a function intended for end-users. Lynn