unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lynn Winebarger <owinebar@gmail.com>
To: Andrea Corallo <akrl@sdf.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Joseph Mingrone <jrm@ftfl.ca>,
	emacs-devel <emacs-devel@gnu.org>,
	emacs@freebsd.org
Subject: Re: --with-native-compilation build failure on 32-bit systems
Date: Tue, 9 Aug 2022 06:20:23 -0400	[thread overview]
Message-ID: <CAM=F=bCUhrif-Boq2B-b8jFu5GpaEiMi9TAdofiq-0dqt8DTxA@mail.gmail.com> (raw)
In-Reply-To: <xjfk07hixh4.fsf@ma.sdf.org>

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On Tue, Aug 9, 2022, 5:22 AM Andrea Corallo <akrl@sdf.org> wrote:

> Andrea Corallo <akrl@sdf.org> writes:
>
> [...]
>
> > Just had some time to look into this further:
> >
> > Of all the CUs we are dumping two are not fixed-up in loadup.el before
> > dump because not referenced by any function.
> >
> > In particular looking at 'ediff-hook' it does contain only variable
> > definitions so this is correct.
> >
> > We do run a GC before dumping so we should unload these unreferenced CUs
> > before dump.  And as expected I don't see ediff-hook CU being marked but
> > we do not free it during sweep.
> >
> > It looks to me like a GC bug so far.  Unfortunatly I've very constrained
> > time to dedicate on this this week.
>
> Thinking about this... Maybe relying on the GC for this is not a very
> good idea in the first place.  If we are conservative on the stack my
> might always mark a CU accidentally and fall into the same issue.
>
> I think we should maintain a list of all loaded CUs so we can fix them
> up reliably.  If this is agreed not to be a bad idea I'll prepare a
> patch.


Just a heads up - when I was validating what was failing while dumping, I
tried printing the comp units before and after they were fixed up.  When
the comp unit has a cons cell in the name field, princ segfaults (at least
in 28.1).
I didn't report this as a bug because it would be very unusual for a user
to have access to comp units in this state.

Lynn






>

[-- Attachment #2: Type: text/html, Size: 2351 bytes --]

  parent reply	other threads:[~2022-08-09 10:20 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  2:12 --with-native-compilation build failure on 32-bit systems Joseph Mingrone
2022-08-05 11:58 ` Lars Ingebrigtsen
2022-08-05 13:30   ` Andrea Corallo
2022-08-05 14:40     ` Andrea Corallo
2022-08-05 15:16       ` Lynn Winebarger
2022-08-08  7:44         ` Andrea Corallo
2022-08-08 10:22           ` Lynn Winebarger
2022-08-08 13:14             ` Andrea Corallo
2022-08-08 13:55               ` Lynn Winebarger
2022-08-08 14:13                 ` Andrea Corallo
2022-08-09  9:11       ` Andrea Corallo
2022-08-09  9:21         ` Andrea Corallo
2022-08-09  9:48           ` Po Lu
2022-08-09 10:03             ` Andrea Corallo
2022-08-09 10:10               ` Po Lu
2022-08-09 10:20           ` Lynn Winebarger [this message]
2022-08-09 11:16           ` Eli Zaretskii
2022-08-17 19:59             ` Andrea Corallo
2022-08-17 21:01               ` Andrea Corallo
2022-08-18  5:30                 ` Eli Zaretskii
2022-08-18  8:06                   ` Andrea Corallo
2022-08-18  8:15                     ` Eli Zaretskii
2022-08-18  9:08                       ` Andrea Corallo
2022-08-18  8:31                     ` Po Lu
2022-08-18 11:48                     ` Joseph Mingrone
2022-08-18 13:40                   ` Stefan Monnier
2022-08-18 13:47                     ` Lynn Winebarger
2022-08-18 14:49                     ` Andrea Corallo
2022-08-18  5:17               ` Eli Zaretskii
2022-08-18  7:59                 ` Andrea Corallo
2022-08-18  8:14                   ` Eli Zaretskii
2022-08-18  9:06                     ` Andrea Corallo
2022-08-18  9:45                       ` Eli Zaretskii
2022-08-18  9:57                         ` Andrea Corallo
2022-08-18 10:31                           ` Eli Zaretskii
2022-08-18 11:08                             ` Andrea Corallo
2022-08-18 13:08                               ` Eli Zaretskii
2022-08-18 14:09                                 ` Andrea Corallo
2022-08-18 14:22                                   ` Eli Zaretskii
2022-08-18 14:50                                     ` Andrea Corallo
2022-08-18 15:57                                       ` Eli Zaretskii
2022-08-18 16:42                                         ` Andrea Corallo
2022-08-18 17:11                                           ` Eli Zaretskii
2022-08-18 19:35                                             ` Andrea Corallo
2022-08-19  5:49                                               ` Eli Zaretskii
2022-08-19  8:11                                                 ` Andrea Corallo
2022-08-09 15:32           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM=F=bCUhrif-Boq2B-b8jFu5GpaEiMi9TAdofiq-0dqt8DTxA@mail.gmail.com' \
    --to=owinebar@gmail.com \
    --cc=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=emacs@freebsd.org \
    --cc=jrm@ftfl.ca \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).