From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.devel Subject: Re: Regression in dump-emacs-portable Date: Tue, 14 Feb 2023 18:26:07 -0500 Message-ID: References: <83ttzocomk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14720"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 15 00:27:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pS4hb-0003dl-W3 for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Feb 2023 00:27:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pS4gq-0007tf-Lk; Tue, 14 Feb 2023 18:26:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pS4gp-0007s0-A6 for emacs-devel@gnu.org; Tue, 14 Feb 2023 18:26:23 -0500 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pS4gn-0004Hi-Go; Tue, 14 Feb 2023 18:26:22 -0500 Original-Received: by mail-pj1-x1032.google.com with SMTP id oa11-20020a17090b1bcb00b002341a2656e5so299710pjb.1; Tue, 14 Feb 2023 15:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZSDbwZS6srIYfPRHr0JteYqY//n48VqdnGdnxZFDEfc=; b=cpiT38PdKkMe1oH31yvaBb7r8mjVZvAQAMaLJ864kVkdQ+lwzngVGZGhuE3Q/G7pQT iEx+toFoLaxmV4Y+qF0y3LPng5RVGHahaQqT9Hl1pzJ6puD7rNy/3INC9b14qbUW71H3 z1EbbxeGeqN6eL8nf/a+U/TW1Qk6JcU8pF1Yunh8MHTufrWioFCvkNuKMJqXanBoBaVY iuim/42w8LS3sJS6kdfWgqzkcv2L7RJajdiDD+Tcsw8Ph3RJFzoCacx1w6OBVJVO3Cr4 ohXu95egJbzt+toMnuvdieRkJUjJdkTuqH0ymkZUmGW5we7b73Gs8B7KPdLfkcZHT6iS KCbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZSDbwZS6srIYfPRHr0JteYqY//n48VqdnGdnxZFDEfc=; b=AyNioU+ailnd3XUwJcPDAVCpyXLz/SsCcL4Pu5mpWnFFCSkGjAKf60NWiJE51CpuHv qPWstO3+SlgDz0GVU0s/YGxB5K0AB44Jxa3irj8KyG69QmjNr6naatQypxdDJA6GXiI4 VowdHN88g0bxcV6nRK4r+GGmJnhF13KoyOwyfDj6bO6cCGA4wfkLORppSa9UZ2Js7Uld S1vHbupi3B1ocyir+yyf7dDEVs/glOF4S+VW6ycW81Gc6GPw8UOP/Jipxme1bmv6VM44 bGKV1A/+XOPKp6yAwmaeL9MpT5ueWdz/78A6wT1zH9TJAH9WcN06YrY9Ii7YmKURDgcZ q8EQ== X-Gm-Message-State: AO0yUKWL7S0TguVD7ZH94lKX3FHxh1sHKdMs1gq8cddm5mrM5+3BDQe0 RhRMFezmoRzox0m3nxWdqFrB1ZU81VM8ApjXyN11v4fq X-Google-Smtp-Source: AK7set+8kppY1n+jElYd7+KgxxZG1zFvsK8dp0ow4SkxC6eTY2P0KGYMmNWXEAPtCWSBUx1Fcz02cptAYbgkU3FTjBU= X-Received: by 2002:a17:902:e545:b0:19a:887a:3f8f with SMTP id n5-20020a170902e54500b0019a887a3f8fmr91075plf.7.1676417179296; Tue, 14 Feb 2023 15:26:19 -0800 (PST) In-Reply-To: <83ttzocomk.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=owinebar@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303292 Archived-At: On Tue, Feb 14, 2023 at 9:23 AM Eli Zaretskii wrote: > > > From: Lynn Winebarger > > Date: Mon, 13 Feb 2023 20:13:22 -0500 > > > > I also looked for tests of dump-emacs-portable in the test/ > > subdirectory, and grep reported nothing. I can translate my shell > > script into elisp to run under ERT, and add testing for each of the > > libraries expected to be dumpable (in the sense of not requiring code > > evaluated on load that needs to be delayed until run-time) > > individually. How do I submit that? Are there any restrictions I > > should observe? > > What do these tests actually test? Whether libraries expected to be redumpable are in fact redumpable. Almost every library in 28.2 could be redumped, excepting those which simply failed to load for whatever reason. Even the ones that need to be delayed until initialization for practical reasons do not cause dump-emacs-portable to fail. A library changing from dumpable to non-dumpable might be acceptable, but that change has to be known to evaluate the tradeoff. Additionally, whether the maximal set of files expected to be redumpable is redumpable as a whole. If the maximal set can be redumped, then presumably any proper subset (closed under require) could be as well. Obviously someone's been optimizing something to see the maximal redump size decrease by 45%. The total number of libraries (excluding the obsolete directory) appears to have decreased, but enough to explain that much of a change in size? Lynn