From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lynn Winebarger Newsgroups: gmane.emacs.devel Subject: Re: Policy on pure space-related fixes Date: Tue, 2 Aug 2022 02:06:30 -0400 Message-ID: References: <83czdm688i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26386"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 02 08:09:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIl5s-0006in-44 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Aug 2022 08:09:28 +0200 Original-Received: from localhost ([::1]:49870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIl5q-0002Ii-Tr for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Aug 2022 02:09:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIl3Q-0000uY-Uz for emacs-devel@gnu.org; Tue, 02 Aug 2022 02:06:57 -0400 Original-Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:33648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIl3G-000347-7j; Tue, 02 Aug 2022 02:06:56 -0400 Original-Received: by mail-pj1-x102e.google.com with SMTP id f11-20020a17090a4a8b00b001f2f7e32d03so930897pjh.0; Mon, 01 Aug 2022 23:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RWEjsJNe3RZ121LeZtdX/EYT4DmdQxrDHWYCA1FD824=; b=UoGGDhpJ4vEI/yZLNHNcXzS2EBmZlbs2Um2kUJ8Cj6Cx/k175ZnXbB1Zl3r+ON7/XK 6ZkmkVLDArLFzYJHDxQHq2VEdFiLLFvfFp8EAp6Tk2NkHrEvu7n5yH7mb8/DkgZPHwOt mGV+fM9sdUp3zJMP6sOqX5b6xFfUm4VUe/YfMwu58sz6cbTipAnegVCfvYHdQrXBtGXz 0I9W1FW6cL9L8Gce7FB9dZ3ce0iKw8SSUJx1I7RetnMgPLgo8UxZAJsAE77CS6AncZSe QV5sAFT27PkwQDxSn9aeFC9xexItlCXQIVDiSz4nlTboKPTD1xPs5Kbs5z5e8cCFpwQF eGpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RWEjsJNe3RZ121LeZtdX/EYT4DmdQxrDHWYCA1FD824=; b=jhEWUY8HSPSr3aD8xhgy6/4CZqEYN3wPZ/gsG2udwGPhc1S/ngX+supagTy5t86+5t lmec2vs2NlOF351V0V36gw0Hbm37oc9GDnsV7K+Bs3krpdEdtiXdw8hU9ZYwtg2b8kux pBUNesXv/i3YB8iNuzQs8cVKb8KcIMzSxAiDg+ZXWQUV8m1e63GLdikK3Et9YzfbgMdc urKj4K0tGcTlj6mGscLVa7SVLBc723OAQaUNpcM6XbtNCcsWqlAmfH6sjsBIgwL6AlDq 539xkUQNzd2KBAcs4u8YCjz0l3HanHkDxJIqeEZE31d81DwlsO8ppi1czdnEsdb/y13R 1ufA== X-Gm-Message-State: ACgBeo2QO3+LYEf75CdyChyYlGSm3r6fSeWNruvjAGt6ZWyBfrikAl8v /sL/RQ128YHchDtnKn8myDB5fWa+3eSYIgn5GeUbMCue X-Google-Smtp-Source: AA6agR4jDBjwtHYXZ9U7KqJyFVL8Dc+1WfcwXXDyGXyFppui07puVus5T+2ouZgnWnNFEuUVmAcswy+xgzEGtmVYLOc= X-Received: by 2002:a17:90a:2948:b0:1f3:1b42:a810 with SMTP id x8-20020a17090a294800b001f31b42a810mr23337007pjf.203.1659420402747; Mon, 01 Aug 2022 23:06:42 -0700 (PDT) In-Reply-To: <83czdm688i.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=owinebar@gmail.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292969 Archived-At: On Sat, Jul 30, 2022 at 9:27 AM Eli Zaretskii wrote: > > > From: Lynn Winebarger > > Date: Sat, 30 Jul 2022 07:45:21 -0400 > > > > Generally, are fixes to pure space worth submitting, given the plan to decommission it, or will they just be > > ignored? I'm still waiting on clearance from my employer to submit patches, unfortunately. > > It depends on the purpose of the change. If the unexec build is > broken due to that, we will increase the pure space. But I don't see > a reason to do that to cater to a build that we don't yet support, so > I suggest you do that locally (since you are making a lot of local > changes anyway). Now that I have a basic grasp of the bootstrap and dumping process, I've written a script invoked from my site-load (only during a non-bootstrap dump) that builds a normal emacs dump in situ, moves that to emacs-1 (and emacs-1.pdmp), then byte-compiles all the required files in the site-load.el file using emacs-1 and extracts the docstrings, before proceeding with the usual build. It's basically the process Stefan M described for a three stage bootstrap, but without modifying the configure/Makefiles to make it happen. I'm able to run the dump without modifying any lisp files, though I've made a few modifications to alloc.c to fix the segfaults/runaway allocation issues, and to lread.c to add a "docstring-hack" variable so I can explicitly turn off the docstring hack in site-load.el. I also have to flip the purify flag off on some of the files that modify variables declared with defconst. The build makes it up to the dumping step, at least, but then is either stuck in a loop of some kind or processing an incredibly large mark-compact GC algorithm. I stopped it after a couple of hours. I'm going to try adding files in smaller chunks (than the 511 or so I added) to see where the dumping procedure goes off the rails. I'm going to try an accurate solution to dealing with cyclic structures by purecopy as well, to see if I can get rid of the other segfaults as well. Lynn