From: Lynn Winebarger <owinebar@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Regression in dump-emacs-portable
Date: Fri, 17 Feb 2023 18:44:18 -0500 [thread overview]
Message-ID: <CAM=F=bBW=bye4zrppUue8SYGJsJbsN_UBQSbt1kVBegYC5aMQQ@mail.gmail.com> (raw)
In-Reply-To: <83bkls1hzn.fsf@gnu.org>
On Fri, Feb 17, 2023 at 9:31 AM Eli Zaretskii <eliz@gnu.org> wrote:
> I don't understand what will this solve. Why does it matter when
> exactly is a variable initialized, if in any case that will happen
> before re-dumping?
You're right with respect to the current definitions of
custom-initialize-* functions that will only set variables if they are
unbound.
The docstring for custom-initialize-delay is:
"Delay initialization of SYMBOL to the next Emacs start.
This is used in files that are preloaded (or for autoloaded
variables), so that the initialization is done in the run-time
context rather than the build-time context. This also has the
side-effect that the (delayed) initialization is performed with
the :set function."
But "so the initialization is done in the run-time context" and "to
the *next* Emacs start" (emphasis mine) are contradictory unless
dumping can only happen once. The first sentence should be "Ensure
SYMBOL is set to initial-value at Emacs startup". Otherwise, the
"initialization" will only reflect the value of the customization when
it was first set, regardless of whether that value reflects the
*current* run-time context due to redumping. In particular, currently
redumping has to happen in a noninteractive context, so redumping of a
customization with an initialization expression referencing the value
of 'noninteractive will not be correct when it is later used in an
interactive session. Also, any customization variables introduced
after a redump that are supposed to be initialized by
#'custom-initialize-delay will not be initialized on the next startup,
since custom-delayed-init-variables is already set to t in the dump.
The current implementation only works for customization variables
defined in the initial dump.
I'll take a shot at a more thorough rewrite of the customization
system to properly support redumping this weekend and send another
patch.
Lynn
next prev parent reply other threads:[~2023-02-17 23:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 0:51 Regression in dump-emacs-portable Lynn Winebarger
2023-02-14 1:13 ` Lynn Winebarger
2023-02-14 14:23 ` Eli Zaretskii
2023-02-14 23:26 ` Lynn Winebarger
2023-02-15 12:42 ` Eli Zaretskii
2023-02-16 9:31 ` Lynn Winebarger
2023-02-16 9:54 ` Lynn Winebarger
2023-02-16 15:05 ` Lynn Winebarger
2023-02-16 15:34 ` Eli Zaretskii
2023-02-16 23:45 ` Lynn Winebarger
2023-02-17 13:22 ` Lynn Winebarger
2023-02-17 14:31 ` Eli Zaretskii
2023-02-17 23:44 ` Lynn Winebarger [this message]
2023-02-18 7:07 ` Eli Zaretskii
2023-02-21 14:21 ` Lynn Winebarger
2023-02-23 2:41 ` Lynn Winebarger
2023-02-23 13:21 ` Lynn Winebarger
2023-02-16 15:46 ` Eli Zaretskii
2023-02-17 1:29 ` Lynn Winebarger
2023-02-17 3:19 ` Lynn Winebarger
2023-02-17 4:10 ` Lynn Winebarger
2023-02-17 5:21 ` Po Lu
2023-02-17 12:57 ` Lynn Winebarger
2023-02-23 15:08 ` Gregory Heytings
2023-02-23 22:32 ` Lynn Winebarger
2023-02-25 4:11 ` Richard Stallman
2023-02-25 4:11 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=F=bBW=bye4zrppUue8SYGJsJbsN_UBQSbt1kVBegYC5aMQQ@mail.gmail.com' \
--to=owinebar@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).