From: Lynn Winebarger <owinebar@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Andrea Corallo <akrl@sdf.org>, emacs-devel@gnu.org
Subject: Re: native compilation units
Date: Tue, 14 Jun 2022 10:55:37 -0400 [thread overview]
Message-ID: <CAM=F=bAizrsqACTDppwfuQ7YNRLPrdDjLGh6Us7+8fhHizEgaw@mail.gmail.com> (raw)
In-Reply-To: <jwvsfo75tbl.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
I think you may be remembering an intention to implement that. The issue
came up in 2009 (before the byte-compiler
even caught the error), and there's only the initial patch you committed to
signal the error:
https://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/emacs-lisp/bytecomp.el?id=8476cfaf3dadf04379fde65cd7e24820151f78a9
and one more changing a variable name:
https://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/emacs-lisp/bytecomp.el?id=d9bbf40098801a859f4625c4aa7a8cbe99949705
so lines 954-961 of bytecomp.el still read:
(dolist (bytes-tail patchlist)
(setq pc (caar bytes-tail)) ; Pick PC from goto's tag.
;; Splits PC's value into 2 bytes. The jump address is
;; "reconstructed" by the `FETCH2' macro in `bytecode.c'.
(setcar (cdr bytes-tail) (logand pc 255))
(setcar bytes-tail (ash pc -8))
;; FIXME: Replace this by some workaround.
(or (<= 0 (car bytes-tail) 255) (error "Bytecode overflow")))
I mainly quote this to say: see what I mean about losing starting off as
putting aside temporarily? :-)
I sent in the bug report.
On Tue, Jun 14, 2022 at 8:23 AM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> > Or, you could just create a vector with one thunk for each package and
> > loop through it invoking each one. It wouldn't be as space
> > efficient, but it would be trivially correct.
>
> IIRC the compiler has code to split a bytecode object into two to try
> and circumvent the 64k limit and it should definitely be applicable here
> (it's more problematic when it's inside a loop), which is why I think
> it's a plain bug.
>
>
> Stefan
>
>
[-- Attachment #2: Type: text/html, Size: 2528 bytes --]
next prev parent reply other threads:[~2022-06-14 14:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 1:02 native compilation units Lynn Winebarger
2022-06-01 13:50 ` Andrea Corallo
2022-06-03 14:17 ` Lynn Winebarger
2022-06-03 16:05 ` Eli Zaretskii
[not found] ` <CAM=F=bDxxyHurxM_xdbb7XJtP8rdK16Cwp30ti52Ox4nv19J_w@mail.gmail.com>
2022-06-04 5:57 ` Eli Zaretskii
2022-06-05 13:53 ` Lynn Winebarger
2022-06-03 18:15 ` Stefan Monnier
2022-06-04 2:43 ` Lynn Winebarger
2022-06-04 14:32 ` Stefan Monnier
2022-06-05 12:16 ` Lynn Winebarger
2022-06-05 14:08 ` Lynn Winebarger
2022-06-05 14:46 ` Stefan Monnier
2022-06-05 14:20 ` Stefan Monnier
2022-06-06 4:12 ` Lynn Winebarger
2022-06-06 6:12 ` Stefan Monnier
2022-06-06 10:39 ` Eli Zaretskii
2022-06-06 16:23 ` Lynn Winebarger
2022-06-06 16:58 ` Eli Zaretskii
2022-06-07 2:14 ` Lynn Winebarger
2022-06-07 10:53 ` Eli Zaretskii
2022-06-06 16:13 ` Lynn Winebarger
2022-06-07 2:39 ` Lynn Winebarger
2022-06-07 11:50 ` Stefan Monnier
2022-06-07 13:11 ` Eli Zaretskii
2022-06-14 4:19 ` Lynn Winebarger
2022-06-14 12:23 ` Stefan Monnier
2022-06-14 14:55 ` Lynn Winebarger [this message]
2022-06-08 6:56 ` Andrea Corallo
2022-06-11 16:13 ` Lynn Winebarger
2022-06-11 16:37 ` Stefan Monnier
2022-06-11 17:49 ` Lynn Winebarger
2022-06-11 20:34 ` Stefan Monnier
2022-06-12 17:38 ` Lynn Winebarger
2022-06-12 18:47 ` Stefan Monnier
2022-06-13 16:33 ` Lynn Winebarger
2022-06-13 17:15 ` Stefan Monnier
2022-06-15 3:03 ` Lynn Winebarger
2022-06-15 12:23 ` Stefan Monnier
2022-06-19 17:52 ` Lynn Winebarger
2022-06-19 23:02 ` Stefan Monnier
2022-06-20 1:39 ` Lynn Winebarger
2022-06-20 12:14 ` Lynn Winebarger
2022-06-20 12:34 ` Lynn Winebarger
2022-06-25 18:12 ` Lynn Winebarger
2022-06-26 14:14 ` Lynn Winebarger
2022-06-08 6:46 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM=F=bAizrsqACTDppwfuQ7YNRLPrdDjLGh6Us7+8fhHizEgaw@mail.gmail.com' \
--to=owinebar@gmail.com \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).