Re: Adding with-editor to Emacs?

[Lynn Winebarger <owinebar@gmail.com>]

On Sun, Sep 3, 2023 at 1:22 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Lynn Winebarger <owinebar@gmail.com>
> >
> > Just to put it out there, wouldn't putting the basic function in core
> > emacs, without all the workarounds for packaging fails, put the onus
> > on the packager to either adhere to the standard layout or patch their
> > distribution to make the function work accordingly?  That seems like
> > one of the benefits of a package being included in the core.
>
> I don't think I understand what you are saying here.  At least one
> sentence failed to parse.

It seemed to me the problems Jonas described with finding the correct
emacsclient binary resulted from the library being in an external
package rather than part of the GNU Emacs distribution.
That is, if the "with-editor" function were
* implemented in a core emacs library following the simple approach
you suggested, based on the built-in expected location of emacsclient
* had a test to verify this function works when installed
then failures due to odd packaging conventions or plain oversight
would be the responsibility of the emacs packager/distribution.  The
failures could be fixed either by adopting the standard layout or by
patching the emacs distribution.  Either way, it would not be the
concern of the core emacs maintainer of the library containing the
with-editor function.

That is one of the benefits of being upstream  from emacs
distributions (as a GNU emacs contributor) instead of "downstream" of
the distribution as a package author.  At least, it would seem that
way.

Lynn