At first glance everything looks good to me. I was extremely happy to see you've fixed the indentation for:

if foo &&
   bar
end

The old (incorrect) behaviour was quite an annoyance for many Ruby programmers.



On 11 November 2013 14:56, Dmitry Gutov <dgutov@yandex.ru> wrote:
Bozhidar Batsov <bozhidar@batsov.com> writes:

> I've just noticed that issue myself. Is there any progress on it?

Yes. Try the latest trunk, and check out the examples in
test/indent/ruby.rb. All of them currently work (or else there would be
a comment saying that some don't).

If you have any new broken examples or disagree with some of the choices
in ruby.rb, please tell.

>
> On 7 November 2013 18:02, Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>
>     >>> Is it at all possible to change the grammar this way?
>     >> You'd probably have to use a trick similar to the " @ " used on
>     the
>     >> space between the method name and the multiple-args.
>     > Ah, okay. Sounds not very efficient, performance-wise.
>
>
>     Could be. Every trick we add to the tokenizer is a potential
>     performance problem, indeed. On the contrary, code in the
>     rules-function is generally not performance sensitive.
>
>
>     Stefan
>
>