unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bozhidar Batsov <bozhidar@batsov.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: ruby-mide, SMIE and token priority
Date: Mon, 11 Nov 2013 17:13:34 +0200	[thread overview]
Message-ID: <CAM9Zgm3D0CQt-4wn37JR4Fdspfqn=tBexg_OWqPqfRpF_hjxuw@mail.gmail.com> (raw)
In-Reply-To: <87bo1rqep1.fsf@yandex.ru>

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

At first glance everything looks good to me. I was extremely happy to see
you've fixed the indentation for:

if foo &&
   bar
end

The old (incorrect) behaviour was quite an annoyance for many Ruby
programmers.



On 11 November 2013 14:56, Dmitry Gutov <dgutov@yandex.ru> wrote:

> Bozhidar Batsov <bozhidar@batsov.com> writes:
>
> > I've just noticed that issue myself. Is there any progress on it?
>
> Yes. Try the latest trunk, and check out the examples in
> test/indent/ruby.rb. All of them currently work (or else there would be
> a comment saying that some don't).
>
> If you have any new broken examples or disagree with some of the choices
> in ruby.rb, please tell.
>
> >
> > On 7 November 2013 18:02, Stefan Monnier <monnier@iro.umontreal.ca>
> > wrote:
> >
> >     >>> Is it at all possible to change the grammar this way?
> >     >> You'd probably have to use a trick similar to the " @ " used on
> >     the
> >     >> space between the method name and the multiple-args.
> >     > Ah, okay. Sounds not very efficient, performance-wise.
> >
> >
> >     Could be. Every trick we add to the tokenizer is a potential
> >     performance problem, indeed. On the contrary, code in the
> >     rules-function is generally not performance sensitive.
> >
> >
> >     Stefan
> >
> >
>

[-- Attachment #2: Type: text/html, Size: 2081 bytes --]

  reply	other threads:[~2013-11-11 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  3:18 ruby-mide, SMIE and token priority Dmitry Gutov
2013-11-07  4:30 ` Stefan Monnier
2013-11-07 13:10   ` Dmitry Gutov
2013-11-07 16:02     ` Stefan Monnier
2013-11-11  9:14       ` Bozhidar Batsov
2013-11-11 12:56         ` Dmitry Gutov
2013-11-11 15:13           ` Bozhidar Batsov [this message]
2013-11-11 17:19             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM9Zgm3D0CQt-4wn37JR4Fdspfqn=tBexg_OWqPqfRpF_hjxuw@mail.gmail.com' \
    --to=bozhidar@batsov.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).