From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Small improvements to ruby-mode Date: Sat, 6 Jul 2013 08:31:45 +0300 Message-ID: References: <2A6700DEDCA640EF92B326002717596D@gmail.com> <87txkrm46t.fsf@yandex.ru> <6EF2AEF8D67840A2AF1C908AA3D0725F@gmail.com> <51C5A67A.2020002@yandex.ru> <51C6EA5F.2040408@yandex.ru> <51D1CB5A.2060900@yandex.ru> <51D1F98D.3060900@yandex.ru> <51D31E12.7060002@yandex.ru> <51D4476A.40107@yandex.ru> <51D6A02C.2020207@yandex.ru> <51D6D500.7080306@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d04446b4388b46904e0d120f9 X-Trace: ger.gmane.org 1373088718 24894 80.91.229.3 (6 Jul 2013 05:31:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Jul 2013 05:31:58 +0000 (UTC) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 06 07:31:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UvL6D-0003xB-LM for ged-emacs-devel@m.gmane.org; Sat, 06 Jul 2013 07:31:57 +0200 Original-Received: from localhost ([::1]:60926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvL6D-0006ft-62 for ged-emacs-devel@m.gmane.org; Sat, 06 Jul 2013 01:31:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvL66-0006fd-D4 for emacs-devel@gnu.org; Sat, 06 Jul 2013 01:31:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UvL62-0007et-24 for emacs-devel@gnu.org; Sat, 06 Jul 2013 01:31:50 -0400 Original-Received: from mail-qa0-x230.google.com ([2607:f8b0:400d:c00::230]:63393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvL61-0007ep-SN for emacs-devel@gnu.org; Sat, 06 Jul 2013 01:31:45 -0400 Original-Received: by mail-qa0-f48.google.com with SMTP id cm16so1521814qab.14 for ; Fri, 05 Jul 2013 22:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=N67VJYVvhohBs2czjTwpWYSA2arxL/Ne4bAXn5T4XSE=; b=k3pWDB9w3Z2vCn9tSLWu0808rqNl23AWfR5LRouTgeU74m/InN9Kik3bGUdRNX/yeQ jFHfm9DXGX/lvxcR5Mg8Fz+ahnkjtlohpEFIWJGH/667TWnWiMfWIQlg3pH3wPcV9E+L C8pEpnZ6K76fNAZyfO5PsZNVQXqqU7dPX7IFaTKfnMfNewuoFgEMHD2gjVSoFvz1JCtX pxb+GEk/u8MWM4ivryrUkqHN62kU9CfUae7fB5/roPURsIkeH2Ct7BEB+i/PrgHwtDxV UlVmX24DwbZgSVcHpquYOOoM+gseZBK1exPi0B6eTLo4O99/w+aYgB6b7CnRSY6VTMDy VBbA== X-Received: by 10.229.158.206 with SMTP id g14mr1803839qcx.22.1373088705457; Fri, 05 Jul 2013 22:31:45 -0700 (PDT) Original-Received: by 10.49.59.13 with HTTP; Fri, 5 Jul 2013 22:31:45 -0700 (PDT) In-Reply-To: <51D6D500.7080306@yandex.ru> X-Google-Sender-Auth: Pcj8ZbW1uxQT8umNJDgbTBwuyfs X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161635 Archived-At: --f46d04446b4388b46904e0d120f9 Content-Type: text/plain; charset=UTF-8 On 5 July 2013 17:15, Dmitry Gutov wrote: > On 05.07.2013 17:01, Bozhidar Batsov wrote: > >> I thought the manual installation instructions were leftovers from the >> old ruby-mode. I was under the impression that since ruby-mode started >> using SMIE it's not a good idea to distribute it separately, since it >> might not behave appropriately on older Emacsen. Perhaps I'm wrong. >> > > SMIE is the way forward, but it still needs work, and it's disabled by > default. Patches welcome, by the way. > > ruby-mode doesn't run on older Emacsen, but it's not hard to fix. Since > earlier versions distributed via Marmalade and Tromey's archive seem to > cause problems, perhaps we should make an effort and upload the current > version to Marmalade, at least once. It stable enough, I think. I guess this makes sense. I've often seen complaints about the ruby-mode in Marmalade being older than the one currently bundled in Emacs. > > > That's unfortunate. Files with tabs look like Christmas trees for most >> whitespace-mode users. >> > > Tabs are colored with whitish-yellow for me, which is the default > whitespace-tab face. Noticeable, but not critical. It's more annoying on a dark background. :-) Obviously that's not a big issue, I'm just obsessed about all the details. > > > Yes, I have - but I really feel that this is something that should be >> handled by ruby-mode itself. After all around 90% of all ruby hackers >> have to deal with yard and rdoc. It's better to have core functionality >> built-in. >> > > We should contact Kyle, then, for the copyright assignment. Or, again, > patches welcome. :) I guess it'd be best of Stefan approached him? > > > * make use of `font-lock-negation-char-face` for ! >> >> >> Uh, okay. Is it different from the default face, in any themes? >> >> If more modes were actually using it more themes would have customised >> it. I can assure you that zenburn and solarized will support it :-) >> > > Any idea how you're going to make it look? > A bold yellowish face seems like a nice option to me. Will make it clear that !orax is not actually lorax for instance. Maybe it should simply derive from the keyword face? On a related note - often && and || are highlighted as keywords. Maybe ruby-mode should do the same for consistency with `and` and `or`? --f46d04446b4388b46904e0d120f9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 5 July 2013 17:15, Dmitry Gutov <<= a href=3D"mailto:dgutov@yandex.ru" target=3D"_blank">dgutov@yandex.ru&g= t; wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
On 05.07.2013 17:01, Bozhidar Batsov wrote:
I thought the manual installation instructions were leftovers from the
old ruby-mode. I was under the impression that since ruby-mode started
using SMIE it's not a good idea to distribute it separately, since it might not behave appropriately on older Emacsen. Perhaps I'm wrong.

SMIE is the way forward, but it still needs work, and it's disabled by = default. Patches welcome, by the way.

ruby-mode doesn't run on older Emacsen, but it's not hard to fix. = =C2=A0Since earlier versions distributed via Marmalade and Tromey's arc= hive seem to cause problems, perhaps we should make an effort and upload th= e current version to Marmalade, at least once. It stable enough, I think.

I guess this makes sense. I've often seen com= plaints about the ruby-mode in Marmalade being older than the one currently= bundled in Emacs. =C2=A0


That's unfortunate. Files with tabs look like Christmas trees for most<= br> whitespace-mode users.

Tabs are colored with whitish-yellow for me, which is the default whitespac= e-tab face. Noticeable, but not critical.

=
It's more annoying on a dark background. :-) Obviously that&= #39;s not a big issue, I'm just obsessed about all the details.


Yes, I have - but I really feel that this is something that should be
handled by ruby-mode itself. After all around 90% of all ruby hackers
have to deal with yard and rdoc. It's better to have core functionality=
built-in.

We should contact Kyle, then, for the copyright assignment. Or, again, patc= hes welcome. :)

I guess it'd be b= est of Stefan approached him?
=C2=A0


=C2=A0 =C2=A0 =C2=A0 =C2=A0 * make use of `font-lock-negation-char-face` fo= r !


=C2=A0 =C2=A0 Uh, okay. Is it different from the default face, in any theme= s?

If more modes were actually using it more themes would have customised
it. I can assure you that zenburn and solarized will support it :-)

Any idea how you're going to make it look?

A bold yellowish face seems like a nice option to me. Will ma= ke it clear that !orax is not actually lorax for instance. Maybe it should = simply derive from the keyword face? On a related note - often && a= nd || are highlighted as keywords. Maybe ruby-mode should do the same for c= onsistency with `and` and `or`?=C2=A0

--f46d04446b4388b46904e0d120f9--