From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template): Date: Sat, 23 Nov 2013 15:23:02 +0200 Message-ID: References: <6vfvqpl5gh.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b2e4edac6c01c04ebd8078b X-Trace: ger.gmane.org 1385212985 31292 80.91.229.3 (23 Nov 2013 13:23:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Nov 2013 13:23:05 +0000 (UTC) Cc: emacs-devel To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 23 14:23:11 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VkDB0-0000vz-8n for ged-emacs-devel@m.gmane.org; Sat, 23 Nov 2013 14:23:10 +0100 Original-Received: from localhost ([::1]:43642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkDAz-0008RF-PO for ged-emacs-devel@m.gmane.org; Sat, 23 Nov 2013 08:23:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkDAw-0008RA-GP for emacs-devel@gnu.org; Sat, 23 Nov 2013 08:23:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkDAv-00011s-DZ for emacs-devel@gnu.org; Sat, 23 Nov 2013 08:23:06 -0500 Original-Received: from mail-oa0-x22e.google.com ([2607:f8b0:4003:c02::22e]:40136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkDAt-00010S-Pv; Sat, 23 Nov 2013 08:23:03 -0500 Original-Received: by mail-oa0-f46.google.com with SMTP id o6so2582705oag.33 for ; Sat, 23 Nov 2013 05:23:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=l+DZCsajc8Xc8iQkfN9QHOU7MJdo9Ve7JnHExsUoH30=; b=pUPJHojjllyA3kG5jVSMd60X082LkXtQwK/c76NsZDLebHCt3bebG5y+MlTfxaM6TN Y92u4mut6QKXtTE3z9BjQiiLUvoIAdLSi75w/SuKrGJhPfpR2Pmba4q6i9mAEnzxvZaq XWm1nYy0dCbtTKz0o0piiW+P74vrfAo+bCLv6MJppX5fSG1035r6jD8sxg4GQm8HHvSE OPlpT6rWc2kVem0le1tue18jNQ6/jAzrZkfI2M8DgZHR8ZIYAlbteUWMgHAVy71rd++q FAhYITudcFgpgWe6yFkq7RImeQZcT6CJfwHU0POwnb3WlVHIKiZcmCGZ5zrcIHTcnPcZ ex7Q== X-Received: by 10.182.80.196 with SMTP id t4mr15675093obx.1.1385212982770; Sat, 23 Nov 2013 05:23:02 -0800 (PST) Original-Received: by 10.76.21.207 with HTTP; Sat, 23 Nov 2013 05:23:02 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: lPX-6kYv3hnJq9ZMri0iIxkJAhA X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165612 Archived-At: --047d7b2e4edac6c01c04ebd8078b Content-Type: text/plain; charset=UTF-8 On 23 November 2013 04:37, Glenn Morris wrote: > > Thanks for adding a test/ChangeLog entry. > Do please list the names of the tests in the entry. > Will do. > ChangeLog entries should name every function, variable that they touch. > I notice this did not happen eg in > http://lists.gnu.org/archive/html/emacs-diffs/2013-11/msg00216.html > which changed an option, added several new functions, and modified > another, but only mentioned the last in the ChangeLog. > Since the new functions were extracted from the modified function I wasn't sure if they needed mentioning. Basically in a situation like this I should list all symbols like this (sym1, sym2...): and write a unified summary regarding all of them, right? > > Similarly > http://lists.gnu.org/archive/html/emacs-diffs/2013-11/msg00150.html > does not list the two new options as entities in their own right. > > Please could you review all your past changes with an eye to that, > and improve the ChangeLogs where necessary? > Sure. > > Also, maybe you want to add a NEWS entry about those new options. > This need be nothing more than: > > ** New Ruby mode options: foo, bar. > Will do. > > in the "Changes in Specialized Modes and Packages in Emacs 24.4" section. > --047d7b2e4edac6c01c04ebd8078b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 23 November 2013 04:37, Glenn Morris = <rgm@gnu.org> wrote:

Thanks for adding a test/ChangeLog entry.
Do please list the names of the tests in the entry.
Will do.
=C2=A0
ChangeLog entries should name every function, variable that they touch.
I notice this did not happen eg in
http://lists.gnu.org/archive/html/emacs-diffs/2013-1= 1/msg00216.html
which changed an option, added several new functions, and modified
another, but only mentioned the last in the ChangeLog.

Since the new functions were extracted from the modified fu= nction I wasn't sure if they needed mentioning.=C2=A0
Basical= ly in a situation like this I should list all symbols like this (sym1, sym2= ...): and write a unified summary regarding
all of them, right?
=C2=A0

Similarly
http://lists.gnu.org/archive/html/emacs-diffs/2013-1= 1/msg00150.html
does not list the two new options as entities in their own right.

Please could you review all your past changes with an eye to that,
and improve the ChangeLogs where necessary?

=
Sure.
=C2=A0

Also, maybe you want to add a NEWS entry about those new options.
This need be nothing more than:

=C2=A0 ** New Ruby mode options: foo, bar.

<= div>Will do.
=C2=A0

in the "Changes in Specialized Modes and Packages in Emacs 24.4" = section.

--047d7b2e4edac6c01c04ebd8078b--