From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Small improvements to ruby-mode Date: Tue, 9 Jul 2013 15:57:03 +0300 Message-ID: References: <2A6700DEDCA640EF92B326002717596D@gmail.com> <87txkrm46t.fsf@yandex.ru> <6EF2AEF8D67840A2AF1C908AA3D0725F@gmail.com> <51C5A67A.2020002@yandex.ru> <51C6EA5F.2040408@yandex.ru> <51D1CB5A.2060900@yandex.ru> <51D1F98D.3060900@yandex.ru> <51D31E12.7060002@yandex.ru> <51D4476A.40107@yandex.ru> <51D6A02C.2020207@yandex.ru> <51D6D500.7080306@yandex.ru> <87bo6e0xct.fsf@yandex.ru> <51DB5C00.5000900@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b6da61690325b04e113b2e6 X-Trace: ger.gmane.org 1373374642 30764 80.91.229.3 (9 Jul 2013 12:57:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2013 12:57:22 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 14:57:24 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UwXTt-0003K0-7O for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2013 14:57:21 +0200 Original-Received: from localhost ([::1]:51532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXTs-0001OO-TE for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2013 08:57:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXTl-0001Mu-1k for emacs-devel@gnu.org; Tue, 09 Jul 2013 08:57:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwXTc-0005iC-3r for emacs-devel@gnu.org; Tue, 09 Jul 2013 08:57:12 -0400 Original-Received: from mail-qe0-x229.google.com ([2607:f8b0:400d:c02::229]:47858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXTb-0005i2-TB for emacs-devel@gnu.org; Tue, 09 Jul 2013 08:57:03 -0400 Original-Received: by mail-qe0-f41.google.com with SMTP id b4so3026248qen.28 for ; Tue, 09 Jul 2013 05:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=i22eNqZtlDJ2IOEe4vGAW4JQ9hxlJBvlEfT9l5c/t90=; b=rFO35BhaK1Q1mOzf43BkFXg3rMkiakeutkPbijkOJptx2b06ndSgsJvO0I+U8w89WF pLS7GbtzhPKum3KfJFYNqXp57l+Qo0Oy3a5aJTbwfFUcTmh1I15qinnKJz6eh0huy1Lm Rx1MR0/RwgQkAV0V0W20iUQ9W1cQZVYp0PqTy1PieWVUZhVwuSzBAtTZXcDCzwv/V8za 732kTb7lJ6TNrDmCGTX2K1MhtgYQKecrT86LjNswvLSfF7sNs753aIzluK9lgIz26vaH HfSnHa3ekUJCFrfChiWC/+vIwDnzmt0fo9yFd9mKWC3NdTnUSNi7drjj0fz0EEpAP9w5 gfGQ== X-Received: by 10.49.95.97 with SMTP id dj1mr20463154qeb.46.1373374623263; Tue, 09 Jul 2013 05:57:03 -0700 (PDT) Original-Received: by 10.49.59.13 with HTTP; Tue, 9 Jul 2013 05:57:03 -0700 (PDT) In-Reply-To: <51DB5C00.5000900@yandex.ru> X-Google-Sender-Auth: CMLmjacW_fFyE25-BTE3AcnUiyI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161750 Archived-At: --047d7b6da61690325b04e113b2e6 Content-Type: text/plain; charset=UTF-8 On 9 July 2013 03:40, Dmitry Gutov wrote: > On 08.07.2013 13:22, Stefan Monnier wrote: > >> a. Ruby trunk has some objectionable code, which I believe we shouldn't >>> merge, and noone seems to be interested in discussing or reverting it: >>> http://bugs.ruby-lang.org/**issues/6854 >>> >> >> "deep-indent", huh? >> > > Yep. Cryptic name and docstring, plus no comments in the code. All par for > the course. :) > > > I don't give it a name in SMIE, but I use the >> "hanging-p" name for the test to choose between doing it or not (which >> seems to be pretty much the same test you use in the current >> ruby-mode.el). >> > > I'm not sure what piece of logic in ruby-mode you mean exactly, but if > SMIE does indentation similar to e.g. js-mode (indentation inside parens > depends on whether the opener is followed by a newline), then that's > behavior I prefer and have in my config via defadvice. ruby-mode currently > picks between "deep" and "not-so-deep" indent based on whether the current > opener is in `ruby-deep-indent-paren'. > > In practice, with SMIE in ruby-mode enabled, I would expect > > foo( > 1, > 2, > 3) > > to be indented as > > foo( > 1, > 2, > 3) > > which doesn't happen. > > > b. They've had a bug about removing ruby-mode.el for months now: >>> http://bugs.ruby-lang.org/**issues/6823Again, no movement there. >>> >> >> Maybe making the trunk code work in 23.4 (for example) would help >> convince people to drop it from ruby-lang. I encourage people to post >> a "vote to remove as well" to this bug-tracker. >> > > Maybe it would. I posted a "me too" there. Me too. Hopefully someone will have a look at the issue at some point. > > > c. No ELPA repositories are tracking Ruby trunk anymore. We just have >>> some older versions uploaded to Marmalade and Tromey's archive a while >>> back. >>> >> >> That's good. So we should indeed upload a newer version (or better >> yet, remove those out dated versions). >> > > https://github.com/nicferrier/**marmalade/issues/55 > > I'm not sure if I should Cc Tom Tromey, after all, his repository is > supposed to be completely out of use. > --047d7b6da61690325b04e113b2e6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



On 9 July 2013 03:40, Dmitry Gutov <dgutov@yandex.ru>= wrote:
On 08.07.2013 13:22, Stefa= n Monnier wrote:
a. Ruby trunk has some objectionable code, which I believe we shouldn't=
merge, and noone seems to be interested in discussing or reverting it:
http://= bugs.ruby-lang.org/issues/6854

"deep-indent", huh?

Yep. Cryptic name and docstring, plus no comments in the code. All par for = the course. :)


I don't give it a name in SMIE, but I use the
"hanging-p" name for the test to choose between doing it or not (= which
seems to be pretty much the same test you use in the current
ruby-mode.el).

I'm not sure what piece of logic in ruby-mode you mean exactly, but if = SMIE does indentation similar to e.g. js-mode (indentation inside parens de= pends on whether the opener is followed by a newline), then that's beha= vior I prefer and have in my config via defadvice. ruby-mode currently pick= s between "deep" and "not-so-deep" indent based on whet= her the current opener is in `ruby-deep-indent-paren'.

In practice, with SMIE in ruby-mode enabled, I would expect

foo(
=C2=A0 =C2=A0 1,
=C2=A0 =C2=A0 2,
=C2=A0 =C2=A0 3)

to be indented as

foo(
=C2=A0 1,
=C2=A0 2,
=C2=A0 3)

which doesn't happen.


b. They've had a bug about removing ruby-mode.el for months now:
http://= bugs.ruby-lang.org/issues/6823 Again, no movement there.

Maybe making the trunk code work in 23.4 (for example) would help
convince people to drop it from ruby-lang. =C2=A0I encourage people to post=
a "vote to remove as well" to this bug-tracker.

Maybe it would. I posted a "me too" there.

<= /div>
Me too. Hopefully someone will have a look at the issue at = some point.
=C2=A0


c. No ELPA repositories are tracking Ruby trunk anymore. =C2=A0We just have=
some older versions uploaded to Marmalade and Tromey's archive a while<= br> back.

That's good. =C2=A0So we should indeed upload a newer version (or bette= r
yet, remove those out dated versions).

https://github.com/nicferrier/marmalade/issues/55
I'm not sure if I should Cc Tom Tromey, after all, his repository is su= pposed to be completely out of use.

--047d7b6da61690325b04e113b2e6--