From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Mark custom function for interactive use only Date: Tue, 26 Nov 2013 08:46:03 +0200 Message-ID: References: <3F18D207-3DA2-4003-B995-A8867E8F0140@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0160b3dc8d190104ec0ed58d X-Trace: ger.gmane.org 1385448374 12428 80.91.229.3 (26 Nov 2013 06:46:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 06:46:14 +0000 (UTC) Cc: Sebastian Wiesner , Stefan Monnier , emacs-devel To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 07:46:16 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VlCPX-0007sQ-EW for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 07:46:15 +0100 Original-Received: from localhost ([::1]:56750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCPW-0004TE-M8 for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 01:46:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCPS-0004T9-DH for emacs-devel@gnu.org; Tue, 26 Nov 2013 01:46:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlCPR-0002y5-Aq for emacs-devel@gnu.org; Tue, 26 Nov 2013 01:46:10 -0500 Original-Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:54915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlCPM-0002xS-4r; Tue, 26 Nov 2013 01:46:04 -0500 Original-Received: by mail-ob0-f182.google.com with SMTP id wp4so5330468obc.41 for ; Mon, 25 Nov 2013 22:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=IdGsItqVNTiDMGpK4ArNGIxYYJZ0b2EkaqdhicdKslk=; b=LAUODfs3/pEjVduPDftu9BZ+bfU/GrKDzwSXdJYwNgKAsCEQ0CPe5Iyo99jpa+eUH2 QQLhnK2eahr7laO3nwH2g/AsQgsOPlM3ViPdVBPA2192lvhHKCszOYJXhabf6I+AWykK x+quKmUkaKg79tkmtLq5dMDONi2AYGnqfJ2chliZ87Ik5ZUJ+VvavjbBzo0urjvAaeSh 4KSlH4yZEbDhWeaKcdG60IwgcCw4SRQDzKZ5ck0VLmsOd5RZWJr/pHnezjhc9sE2POXL OPGsysGnkcpfK97FnX0gdi0LjYG/UOXt1GvMUArJ2lmwJUk2tcWjap1aVi2PBPaOdTQm NIGw== X-Received: by 10.182.48.130 with SMTP id l2mr8640406obn.44.1385448363330; Mon, 25 Nov 2013 22:46:03 -0800 (PST) Original-Received: by 10.76.21.207 with HTTP; Mon, 25 Nov 2013 22:46:03 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: 6YDFME4X8sjCzR3luR6V59O8e90 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165741 Archived-At: --089e0160b3dc8d190104ec0ed58d Content-Type: text/plain; charset=UTF-8 On 26 November 2013 05:18, Glenn Morris wrote: > > When installing changes by others, please think about the copyright > assignment aspect. The rule is, we can accept no more than 10-15 lines > total (cumulative over all changes) from any one person without an > assignment. Changes that fall under that rule should be marked "(tiny > change") in the ChangeLog. > I'm aware of this. I also know Sebastian from working on other projects and he recently mentioned that he has signed the FSF contributor agreement, that's why I didn't brought up the matter. > > I'd say this one qualifies as a tiny change (although it's more than 15 > lines, much of it is mechanical). We would probably need a copyright > assignment to accept any more from this author, though. > Also, please try and use --author when you commit someone else's changes > (Emacs can do this for you). > Actually I committed this with Sebastian as the author, but I did so using a git-bzr bridge and although in git I see him as the committer in bzr it's me. I guess I should apply patches from other people using bzr directly since obviously git-bzr doesn't handle this aspect of the workflow correctly. > > > BTW, I think it would be nicer if I could write: > > (put 'comint-run 'interactive-only 'make-comint) > > instead of: > > (put 'comint-run 'interactive-only "Use `make-comint' instead") > I've been thinking the same thing, but I noticed that some texts were more complex than the common pattern, which is probably the motivation for the use of the string argument. I'll think a bit more how this could be improved further. > > Also, the installed change is inconsistent as to whether "Use `foo' > instead" should end in a period (I guess it should). > > Also also, maybe "; use `foo' instead." with no preceding newline would > look better most of the time? > I'll have a look at this. --089e0160b3dc8d190104ec0ed58d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 26 November 2013 05:18, Glenn Morris = <rgm@gnu.org> wrote:

When installing changes by others, please think about the copyright
assignment aspect. The rule is, we can accept no more than 10-15 lines
total (cumulative over all changes) from any one person without an
assignment. Changes that fall under that rule should be marked "(tiny<= br> change") in the ChangeLog.

I'm= aware of this. I also know Sebastian from working on other projects and he= recently mentioned that he has signed the FSF contributor agreement, that&= #39;s why I didn't brought up the matter.
=C2=A0

I'd say this one qualifies as a tiny change (although it's more tha= n 15
lines, much of it is mechanical). We would probably need a copyright
assignment to accept any more from this author, though.=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
Also, please try and use --author when you commit someone else's change= s
(Emacs can do this for you).

Actually I= committed this with Sebastian as the author, but I did so using a git-bzr = bridge and although in git I see him as the committer in bzr it's me. I= guess I should apply patches from other people using bzr directly since ob= viously git-bzr doesn't handle this aspect of the workflow correctly.
=C2=A0


BTW, I think it would be nicer if I could write:

=C2=A0 (put 'comint-run 'interactive-only 'make-comint)

instead of:

=C2=A0 (put 'comint-run 'interactive-only "Use `make-comint= 9; instead")

I've been thinkin= g the same thing, but I noticed that some texts were more complex than the = common pattern, which is probably the motivation for the use of the string = argument.
I'll think a bit more how this could be improved further.
=C2=A0

Also, the installed change is inconsistent as to whether "Use `foo'= ;
instead" should end in a period (I guess it should).

Also also, maybe "; use `foo' instead." with no preceding new= line would
look better most of the time?

I'll = have a look at this.=C2=A0

--089e0160b3dc8d190104ec0ed58d--