From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Small improvements to ruby-mode Date: Tue, 9 Jul 2013 17:36:25 +0300 Message-ID: References: <2A6700DEDCA640EF92B326002717596D@gmail.com> <87txkrm46t.fsf@yandex.ru> <6EF2AEF8D67840A2AF1C908AA3D0725F@gmail.com> <51C5A67A.2020002@yandex.ru> <51C6EA5F.2040408@yandex.ru> <51D1CB5A.2060900@yandex.ru> <51D1F98D.3060900@yandex.ru> <51D31E12.7060002@yandex.ru> <51D4476A.40107@yandex.ru> <51D6A02C.2020207@yandex.ru> <51D6D500.7080306@yandex.ru> <51DB6516.1090708@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b6da616f24cac04e1151594 X-Trace: ger.gmane.org 1373380607 3248 80.91.229.3 (9 Jul 2013 14:36:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2013 14:36:47 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 16:36:48 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UwZ28-0005cT-IS for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2013 16:36:48 +0200 Original-Received: from localhost ([::1]:34952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwZ28-0002nv-5D for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2013 10:36:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwZ1u-0002mf-3W for emacs-devel@gnu.org; Tue, 09 Jul 2013 10:36:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwZ1m-0000qt-88 for emacs-devel@gnu.org; Tue, 09 Jul 2013 10:36:34 -0400 Original-Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:35314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwZ1m-0000qm-38 for emacs-devel@gnu.org; Tue, 09 Jul 2013 10:36:26 -0400 Original-Received: by mail-qc0-f169.google.com with SMTP id c10so3035424qcz.0 for ; Tue, 09 Jul 2013 07:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=e2fQgIttu9JXs8VVkDbzDHiNv/O6p6gUrhFtP7Soyo4=; b=jRYUnPThND556f0bvGPEYDJyZ0EscYOGLF7MBATgsbWFPmCx9P2vriusDJqGOr6AWA vNobHcnbEHrPZt+CX2NGK/6I3KYKyqHRREkp/T12fL2LOhQkLQkYHmyAMV0+5F1A6fLu znBWZgu0lQPZbgoezNBmauhKiAHpZCkYbm/F6hpzLJc+Va/H2DTGvZ/M951TTOu2s7Ru Y/+LpN8eDLnQu/VO1bGWqS21mLQBBKlBVrWnKnIt8TMkJQj68Nf47vuuotKdTBWIZVsT G9cWuqiZ620JMGGGBANyaVR1ve/SPohYmuxYUAXOoePE7fR6JOAUxQCK+dz9xq7KjlD1 W7HQ== X-Received: by 10.49.95.97 with SMTP id dj1mr20910696qeb.46.1373380585604; Tue, 09 Jul 2013 07:36:25 -0700 (PDT) Original-Received: by 10.49.59.13 with HTTP; Tue, 9 Jul 2013 07:36:25 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: bIycOLTL8cJb4L4_PeuteI1I2Sg X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161753 Archived-At: --047d7b6da616f24cac04e1151594 Content-Type: text/plain; charset=UTF-8 I've noticed two more font look issues (I guess I'm becoming annoying :-) ): - ?c, ?x, ?\n, ?\C-\M-d, etc should be font-locked as strings I guess, since from Ruby 1.9 the character literal syntax actually yields strings. - there should be support for the new %I/%i literals from Ruby 2.0 - I guess we should font-lock them as symbols On 9 July 2013 15:55, Bozhidar Batsov wrote: > Great! > > > On 9 July 2013 04:19, Dmitry Gutov wrote: > >> On 08.07.2013 13:37, Bozhidar Batsov wrote: >> >>> I noticed a couple of more font locking problems that we might want to >>> address. They are related to method names. Consider this code >>> >>> >>> def self.some_name .... >>> >>> def SomeClass.some_name ... >>> >>> self and SomeClass are currently highlighted with the same face as the >>> method name, although they are not actually part of the method name. >>> self should be highlighted with the variable face and class/modules with >>> the type face. >>> >> >> Should be fixed now. :) Along with the negation char fontification. >> > > --047d7b6da616f24cac04e1151594 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've noticed two more font look issues (I guess I'= m becoming annoying :-) ):

- ?c, ?x, ?\n, ?\C-\M-d= , etc should be font-locked as strings I guess, since from Ruby 1.9 the cha= racter literal syntax actually yields strings.

- there should be support for the new %I/%i= literals from Ruby 2.0 - I guess we should font-lock them as symbols
=


On 9 Ju= ly 2013 15:55, Bozhidar Batsov <bozhidar@batsov.com> wrote= :
Great!


On 9 July 2013 04:19, Dmitry Gutov <dgutov@yandex.ru> wrote:<= br>
On 08.07.2013 13:37, Bozhidar Batsov wr= ote:
I noticed a couple of more font locking problems that we might want to
address. They are related to method names. Consider this code


def self.some_name ....

def SomeClass.some_name ...

self and SomeClass are currently highlighted with the same face as the
method name, although they are not actually part of the method name.
self should be highlighted with the variable face and class/modules with the type face.

Should be fixed now. :) Along with the negation char fontification.


--047d7b6da616f24cac04e1151594--