unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bozhidar Batsov <bozhidar@batsov.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] * lisp/subr.el (string-suffix-p): New function.
Date: Fri, 22 Nov 2013 12:00:29 +0200	[thread overview]
Message-ID: <CAM9Zgm0gvoaDfFUASnt0wG8m1C2Af=Ys-bBoBzXpebvkTcQyJA@mail.gmail.com> (raw)
In-Reply-To: <8738mo4x69.fsf@zigzag.favinet>

[-- Attachment #1: Type: text/plain, Size: 1829 bytes --]

I've mentioned only the symmetry, but obviously I think we need this (and a
bunch of other string related functions, since currently the string related
functions are a bit lacking), otherwise I would have not submitted this
suggestion. I've often needed in my code this particular check and I'd
suggest include a few string related functions as well.

Just a quick glance at the number of projects using the third-party string
library s.el (https://github.com/magnars/s.el/blob/master/s.el) should be
all the motivation required to improve upon the existing string functions.
I think it's quite important to provide an API closer to that of popular
programming languages, used often for text processing(Perl, Python, Ruby,
etc). That would include functions like:

* string-join
* string-trim/string-trim-left/string-trim-right
* string-chop
* string-chomp

The best text editor in the world should have an extensive built-in string
manipulation API, right?


On 22 November 2013 11:12, Thien-Thi Nguyen <ttn@gnu.org> wrote:

> () Bozhidar Batsov <bozhidar@batsov.com>
> () Fri, 22 Nov 2013 09:06:10 +0200
>
>    No comments == no objections? :-)
>
> I think symmetry alone is insufficient motivation.  Whether
> or not that design guideline is appropriate here (for Emacs)
> is another question.
>
> Generally, you can make a better case for inclusion if you
> find many places in the code base where the function can be
> used.  Another way to improve its prospects is to show new
> (and cool) code that would not be possible w/o the function.
>
> As i see it, no comments == no invitation.
>
> --
> Thien-Thi Nguyen
>    GPG key: 4C807502
>    (if you're human and you know it)
>       read my lisp: (responsep (questions 'technical)
>                                (not (via 'mailing-list)))
>                      => nil
>

[-- Attachment #2: Type: text/html, Size: 2639 bytes --]

  reply	other threads:[~2013-11-22 10:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 11:24 [PATCH] * lisp/subr.el (string-suffix-p): New function Bozhidar Batsov
2013-11-22  7:06 ` Bozhidar Batsov
2013-11-22  9:12   ` Thien-Thi Nguyen
2013-11-22 10:00     ` Bozhidar Batsov [this message]
2013-11-22 10:15       ` Lars Magne Ingebrigtsen
2013-11-22 10:41         ` Bozhidar Batsov
2013-11-22 14:07           ` Stefan Monnier
2013-11-22 14:27             ` Bozhidar Batsov
2013-11-23  1:44               ` Stefan Monnier
2013-11-23  6:05             ` Josh
2013-11-23 13:57               ` Stefan Monnier
2013-11-23 10:16             ` Stephen J. Turnbull
2013-11-23 17:03           ` Lars Magne Ingebrigtsen
2013-11-22 15:06   ` Jarek Czekalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM9Zgm0gvoaDfFUASnt0wG8m1C2Af=Ys-bBoBzXpebvkTcQyJA@mail.gmail.com' \
    --to=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).