From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Small improvements to ruby-mode Date: Sat, 6 Jul 2013 15:23:57 +0300 Message-ID: References: <2A6700DEDCA640EF92B326002717596D@gmail.com> <87txkrm46t.fsf@yandex.ru> <6EF2AEF8D67840A2AF1C908AA3D0725F@gmail.com> <51C5A67A.2020002@yandex.ru> <51C6EA5F.2040408@yandex.ru> <51D1CB5A.2060900@yandex.ru> <51D1F98D.3060900@yandex.ru> <51D31E12.7060002@yandex.ru> <51D4476A.40107@yandex.ru> <51D6A02C.2020207@yandex.ru> <51D6D500.7080306@yandex.ru> <51D7E542.2050601@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c2bcf2b29da504e0d6e2e7 X-Trace: ger.gmane.org 1373113454 2742 80.91.229.3 (6 Jul 2013 12:24:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Jul 2013 12:24:14 +0000 (UTC) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 06 14:24:16 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UvRX9-0001LE-60 for ged-emacs-devel@m.gmane.org; Sat, 06 Jul 2013 14:24:11 +0200 Original-Received: from localhost ([::1]:36630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvRX8-0001KW-Bb for ged-emacs-devel@m.gmane.org; Sat, 06 Jul 2013 08:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvRX0-0001KQ-SV for emacs-devel@gnu.org; Sat, 06 Jul 2013 08:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UvRWw-0004N4-Fm for emacs-devel@gnu.org; Sat, 06 Jul 2013 08:24:02 -0400 Original-Received: from mail-qe0-x233.google.com ([2607:f8b0:400d:c02::233]:35270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UvRWw-0004N0-9q for emacs-devel@gnu.org; Sat, 06 Jul 2013 08:23:58 -0400 Original-Received: by mail-qe0-f51.google.com with SMTP id a11so1603937qen.38 for ; Sat, 06 Jul 2013 05:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=ScmcklOn9v0P1Ehx5G+1AbDE6woej923NXJQpAShzdg=; b=KXXF+tKN+f0wfTlcl7vGLDYBwEpGkLz+w2dyGLH9F9c2DoSrAmMVVSpbx2QPeXqKVq ZdjuhWiSfemm+yIlkDUZOVOY4p+Hdye7ekQmEBOVizOayIE5tS3Uz46/UL5+lucPmgBX 4KXNChm+TbS5x+dS9XA0kIb7LXGAQsSEgSjcASdBoiyO0OTzGrDx7AUs/kKVixU08A5+ rPBb06i0j09KanaU3pskDvbPDrGxqtvswPuZal+jVLdzxj6jlUyJRdJ8AL/Wk15tpW6U aLQDUol+qhTyFCptndSlecEOo4b3uFiQwGvEocFh6ec/OXM075mxYsGJ5nZIMp1z0CqP VKKQ== X-Received: by 10.224.127.73 with SMTP id f9mr10582040qas.4.1373113437820; Sat, 06 Jul 2013 05:23:57 -0700 (PDT) Original-Received: by 10.49.59.13 with HTTP; Sat, 6 Jul 2013 05:23:57 -0700 (PDT) In-Reply-To: <51D7E542.2050601@yandex.ru> X-Google-Sender-Auth: eAG46D1iQ6dT1jbpTpruqxAAFmQ X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161645 Archived-At: --001a11c2bcf2b29da504e0d6e2e7 Content-Type: text/plain; charset=UTF-8 On 6 July 2013 12:37, Dmitry Gutov wrote: > On 06.07.2013 9:31, Bozhidar Batsov wrote: > >> We should contact Kyle, then, for the copyright assignment. Or, >> again, patches welcome. :) >> >> >> I guess it'd be best of Stefan approached him? >> > > Not necessarily. IME, the hard part is to get the author to agree to this > commitment. Hopefully most authors are delighted by the prospect of their work getting into Emacs :) > > > A bold yellowish face seems like a nice option to me. Will make it clear >> that !orax is not actually lorax for instance. Maybe it should simply >> derive from the keyword face? >> > > I don't think it should: in the default theme, purple negation char would > look odd. Fair point. > > > On a related note - often && and || are > >> highlighted as keywords. Maybe ruby-mode should do the same for >> consistency with `and` and `or`? >> > > I don't think I've ever seen that (e.g. python-mode and coffee-mode > don't). These are not particularly different from other operators, and I > don't think we should highlight them all. > Well, they are different in a way - they have different argument evaluation strategies and cannot be overridden. I don't know about other major modes, but I seem to recall they were highlighted in SublimeText, RubyMine, etc. Don't think that this is something of particular importance, just sharing my thoughts. --001a11c2bcf2b29da504e0d6e2e7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 6 July 2013 12:37, Dmitry Gutov <<= a href=3D"mailto:dgutov@yandex.ru" target=3D"_blank">dgutov@yandex.ru&g= t; wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
On 06.07.2013 9:31, Bozhidar Batsov wrote:
=C2=A0 =C2=A0 We should contact Kyle, then, for the copyright assignment. O= r,
=C2=A0 =C2=A0 again, patches welcome. :)


I guess it'd be best of Stefan approached him?

Not necessarily. IME, the hard part is to get the author to agree to this c= ommitment.

Hopefully most authors are= delighted by the prospect of their work getting into Emacs :)=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">


A bold yellowish face seems like a nice option to me. Will make it clear that !orax is not actually lorax for instance. Maybe it should simply
derive from the keyword face?

I don't think it should: in the default theme, purple negation char wou= ld look odd.

=C2=A0Fair point.=C2=A0<= /div>



> On a related note - often && and || are
highlighted as keywords. Maybe ruby-mode should do the same for
consistency with `and` and `or`?

I don't think I've ever seen that (e.g. python-mode and coffee-mode= don't). These are not particularly different from other operators, and= I don't think we should highlight them all.

Well, they are different in a way - they have differen= t argument evaluation strategies and cannot be overridden. =C2=A0I don'= t know about other major modes, but I seem to recall they were highlighted = in SublimeText, RubyMine, etc. Don't think that this is something of pa= rticular importance, just sharing my thoughts.

--001a11c2bcf2b29da504e0d6e2e7--