From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate. Date: Thu, 31 Oct 2013 21:44:50 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c2d6a0dbac7504ea0eae74 X-Trace: ger.gmane.org 1383248694 4069 80.91.229.3 (31 Oct 2013 19:44:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Oct 2013 19:44:54 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 31 20:44:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbyAr-0003Re-O4 for ged-emacs-devel@m.gmane.org; Thu, 31 Oct 2013 20:44:57 +0100 Original-Received: from localhost ([::1]:59041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbyAr-0002vm-Cy for ged-emacs-devel@m.gmane.org; Thu, 31 Oct 2013 15:44:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbyAm-0002vb-VV for emacs-devel@gnu.org; Thu, 31 Oct 2013 15:44:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbyAl-0005sh-RI for emacs-devel@gnu.org; Thu, 31 Oct 2013 15:44:52 -0400 Original-Received: from mail-oa0-x235.google.com ([2607:f8b0:4003:c02::235]:58274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbyAl-0005sU-Ln for emacs-devel@gnu.org; Thu, 31 Oct 2013 15:44:51 -0400 Original-Received: by mail-oa0-f53.google.com with SMTP id n12so3648176oag.12 for ; Thu, 31 Oct 2013 12:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=L9fVByvOu23YuMyLjMxeZa8M/2l8pz9ewDGeKh5m68c=; b=fIhbHBgZX3Hl+umkSggsILapAxfr0Dotyy0v4mQO9POBxmEdRUo19IvWnIzsGeKjDm qcCzCt9DE+iRurSqYFAlnYSLaQp6S8kv8LnJMTvGurOHiAVaDyaxEB8UxGQTASO9sELq dz2OAGKtCa6zsEb9dJIM0lad5NEraoXcHDJD2XwMCI8ZHlvJQUdP1O5Ef0pO7wE5dQsf kt9qjZMHoNT/0SvFkfkuDAGoixPmzV21n2R7sWa/8H9azcl8PcEJXUH6wZNkD7L64qnq RRRvHNpdgJjBoIZ3ZsiusLo0s/ANv5AZkO0mwbVtm+o536/UYUMBvcx7iB9N6to9Jwbw oISg== X-Received: by 10.182.18.9 with SMTP id s9mr3988392obd.15.1383248690914; Thu, 31 Oct 2013 12:44:50 -0700 (PDT) Original-Received: by 10.76.131.116 with HTTP; Thu, 31 Oct 2013 12:44:50 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: xM0q4U9JNVWHgaFIWXydUktV7G4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164754 Archived-At: --001a11c2d6a0dbac7504ea0eae74 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I think that we don't need to worry about compatibility with the other version of the ruby-mode in Ruby's SVN repo, since just about nobody uses it (except maybe some Emacs 23 users?). ruby-mode suffers from a lot of legacy in it (compared to other built-in modes) and would definitely benefit from a clean up. After all, simpler code is always easier to improve, extend and debug. On 31 October 2013 19:55, Stefan Monnier wrote: > > The attached patch simply replaces (set (make-local-variable =E2=80=A6)= =E2=80=A6) with > > setq-local=E2=80=99 where appropriate in ruby-mode.el. > > Is it OK to use such bleeding-edge constructs in ruby-mode.el, or is > there still some external version with which we should try to preserve > compatibility? > > I meant, the code still tests (functionp 'syntax-ppss), so if we can > drop backward compatibility, there are probably more cleanups ahead. > > > Stefan > --001a11c2d6a0dbac7504ea0eae74 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I think that we don't need to worry about compatibilit= y with the other version of the ruby-mode in Ruby's SVN repo, since jus= t about nobody uses it (except maybe some Emacs 23 users?).=C2=A0

<= /div>
ruby-mode suffers from a lot of legacy in it (compared to other built-= in modes) and would definitely benefit from a clean up. After all, simpler = code is always easier to improve, extend and debug.


On 31 October 2013 19:55, Stefan Monnier= <monnier@iro.umontreal.ca> wrote:
> The attached patch simply replaces (set (make-local-= variable =E2=80=A6)=E2=80=A6) with
> setq-local=E2=80=99 where appropriate in ruby-mode.el.

Is it OK to use such bleeding-edge constructs in ruby-mode.el, or is<= br> there still some external version with which we should try to preserve
compatibility?

I meant, the code still tests (functionp 'syntax-ppss), so if we can drop backward compatibility, there are probably more cleanups ahead.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan

--001a11c2d6a0dbac7504ea0eae74--