From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function. Date: Fri, 13 Dec 2019 07:34:36 -0500 Message-ID: References: <20191030121649.15369.13207@vcs0.savannah.gnu.org> <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org> <87eeyutgwa.fsf@gnus.org> <333d1d46-ab79-5818-4367-b28ed915aff6@yandex.ru> <87a79itfzp.fsf@gnus.org> <875zk6tfo7.fsf@gnus.org> <871ruuou5c.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245401"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Dmitry Gutov , Stefan Monnier , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 13 13:35:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifkAK-0011dJ-VW for ged-emacs-devel@m.gmane.org; Fri, 13 Dec 2019 13:35:29 +0100 Original-Received: from localhost ([::1]:48468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifkAJ-0001p5-OL for ged-emacs-devel@m.gmane.org; Fri, 13 Dec 2019 07:35:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44123) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifk9n-0001nz-9U for emacs-devel@gnu.org; Fri, 13 Dec 2019 07:34:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifk9m-000732-47 for emacs-devel@gnu.org; Fri, 13 Dec 2019 07:34:55 -0500 Original-Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:44942) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifk9l-00071t-US for emacs-devel@gnu.org; Fri, 13 Dec 2019 07:34:54 -0500 Original-Received: by mail-ot1-x32f.google.com with SMTP id x3so6276390oto.11 for ; Fri, 13 Dec 2019 04:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HaBT7KSmLYNRiPCTKxTFxgYlAGsWXqx9qHx8EOpM7zc=; b=Sm6VlEyQUhJPpM5y6MJq2bV15ScsmBgptlh+tWLOpw8EpQpQ3PBPp13td1aXCtY06O yGQlY6SWqt1hjAmAPtPoga0z/9iFeWF69Ft2FowjhK3WEWx6Qm0PaZ3pUH5wvsod+ATM 2UVPo/Refg847zu/CM3/z+VglLXQNEtDf8RgtQVwq7DAl6sJLmNIQcrqdaJIIwYOEry8 bzzkA1eh3dH1JsQRKFHwZtZGBiT8ztWMZXy86dZP9SBDtaspN1ZpJJi19c9Slv9/VxDe 3pyWG8xsoiN2l4CwKWdzKUZqTR8aWaGTr9szuVSO0fg64ByGuvmVUizT3H0Ozx7DA32Q nHew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HaBT7KSmLYNRiPCTKxTFxgYlAGsWXqx9qHx8EOpM7zc=; b=CeY7TPrlF8/2oGq61bYxA4lGyFYkoI0cEcrzIQ3AXNGX3hyvOfnku9B0yLKeOrHJi8 HQkr92aRQzGXrwmV3fhPw17jg05QbH7sAEDtlosrT0EBzw0BeflVyHXRcjzfnX98r9BR MOX4UYkZKxDB8whCNEo8ncxTpGgNOZovzvFjVVsJT8liLIf09DN5YCcvkbGxd9PbdgKh +VYaXQ25jYz4jlQXANSWr/qA1bhmSPbixU9eusYFu3sSyIJDqjyAo35xPmDX26CRLJ8r pComqLDQqreQk3/HusbufRIa9WbVco15AiTeTFi0u2m00EQ3pFyMXoyAuC7/9cHUYXWJ eqOA== X-Gm-Message-State: APjAAAXeD9wqQGHMUZybdqQ+vV9uqWhhOFZp8VLUKkS7P3z8GFwI/cbM kilyBFyu5Cl//t24RWRRReamYaAX3GLzdq/5Wnc= X-Google-Smtp-Source: APXvYqyZsPruAUNFMVYBsq8u+WF/ZOHTFId9QvrBNvxwXihQvcJ0GKxyPGzyPder3xkzZILXGaLR6g9hJVK1ZRYzVH8= X-Received: by 2002:a05:6830:1e9a:: with SMTP id n26mr13475054otr.99.1576240492941; Fri, 13 Dec 2019 04:34:52 -0800 (PST) In-Reply-To: <871ruuou5c.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243350 Archived-At: On Wed, 30 Oct 2019 at 18:22, Lars Ingebrigtsen wrote: > Done (with Dmitry's suggestions). Everybody -- feel free to bikeshed > (and change any of the accessor names) before we start using these. Is it too late to bikeshed the names? ;) I had earlier proposed some slightly shorter ones in https://debbugs.gnu.org/32504#51, posting them here as a diff. @@ -90,30 +90,30 @@ syntax-propertize-extend-region-functions (:copier nil) (:type list)) (depth nil :documentation "depth in parens") - (innermost-start + (list-start nil :documentation "character address of start of innermost containing list; nil if none.") - (last-complete-sexp-start + (last-sexp-start nil :documentation "character address of start of last complete sexp terminated.") (string-terminator nil :documentation "\ non-nil if inside a string. (it is the character that will terminate the string, or t if the string should be terminated by a generic string delimiter.)") - (comment-nesting nil :documentation "\ + (comment nil :documentation "\ nil if outside a comment, t if inside a non-nestable comment, else an integer (the current comment nesting).") - (after-quote-p nil :documentation "t if following a quote character.") - (minimum-paren-depth + (quoted-p nil :documentation "t if following a quote character.") + (min-depth nil :documentation "the minimum paren-depth encountered during this scan.") (comment-style nil :documentation "style of comment, if any.") - (comment-or-string-start + (context-start nil :documentation "character address of start of comment or string; nil if not in one.") - (open-paren-positions + (open-parens nil :documentation "List of positions of currently open parens, outermost first.") - (two-character-syntax nil :documentation "\ + (syntax-sequence nil :documentation "\ When the last position scanned holds the first character of a (potential) two character construct, the syntax of that position, otherwise nil. That construct can be a two character comment