From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: sendmail.el Date: Wed, 24 Aug 2016 21:05:43 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1472087163 24773 195.159.176.226 (25 Aug 2016 01:06:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Aug 2016 01:06:03 +0000 (UTC) Cc: Emacs developers To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 25 03:05:59 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bcj7H-0005zg-01 for ged-emacs-devel@m.gmane.org; Thu, 25 Aug 2016 03:05:59 +0200 Original-Received: from localhost ([::1]:54005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcj7E-00026I-3P for ged-emacs-devel@m.gmane.org; Wed, 24 Aug 2016 21:05:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcj77-00026A-QU for emacs-devel@gnu.org; Wed, 24 Aug 2016 21:05:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcj75-0004bs-QG for emacs-devel@gnu.org; Wed, 24 Aug 2016 21:05:48 -0400 Original-Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:36555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcj72-0004ZZ-FN; Wed, 24 Aug 2016 21:05:44 -0400 Original-Received: by mail-oi0-x22f.google.com with SMTP id f189so47215816oig.3; Wed, 24 Aug 2016 18:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zTf1ErNqCKy+woepf8p9kRcg6MWyXcQ/eHO10gKTlrI=; b=wvnylIywcF+AMrd13b/ihgRGKGTVgwjhyHuK8WALAIjsD9SoNTGeeaqkv+N/5JwQXt sx2bNSxIPWkzoThvSFD/0j8TrebzvhC16i8btJ/NU6x2Y5oIHT3SeQCYD/eXVpIzi1Im K6FXfOnKgAkdmqoKhGKR/vKXZbrDZ1qlU4co/3i9dnmo57ANEtGswC27NJOQSSAUhBS3 6BK25TCNLIFEon2DHiN/xH6V98ee5g5YKB8q2YbojkSOpbjzzAt4CD/IIo3k52Ozh7pI 9Uc93CkFix5+ziPlh9oARj5V6MFRowIAJMq/WCgujIbNBsl/ATvJHVxqhcdQR3Ffey0r SIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zTf1ErNqCKy+woepf8p9kRcg6MWyXcQ/eHO10gKTlrI=; b=Knne17UOoO1FR1WOfbanNqWDP5siPZN7i2d87c/CCvruO14GGpAZT2y+dBCDj4CfRJ hSqxs3Cs1lfBtemQrMGQQ9NU6kzQ1eNoYf0LFSBpMr3a1oyEVtE9WTjpn75evhwyke3X sG3zLHHiSShHj3gDst8364uOCV/irK1ITGIIhhTg+Cvo2pHgU6a60ID7l9oSPkce3ncw CGbjYhOov6DPk38GakjU9BZric1a89wad8yH2tdu8W3om8xag7Q5kbWt91AYG28/57GP o+p4MmnZc4RkRa97Tl3F99T0ZctDr8s5lwFhJ0PDoeh+GlgqSZbqAZkb3JZrjC0Qizim 1aKg== X-Gm-Message-State: AE9vXwPAeFZtI++TJQEXHowDzeNuPOp6EK93zjCoJa0ycO+g3NtF5kQEZJYmFqeq/wyViRLEJIOQVHW40K3aQw== X-Received: by 10.157.24.7 with SMTP id b7mr4783049ote.35.1472087143523; Wed, 24 Aug 2016 18:05:43 -0700 (PDT) Original-Received: by 10.157.7.200 with HTTP; Wed, 24 Aug 2016 18:05:43 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 14-mqIz5RwiURwkszTJIqde9r7M X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206788 Archived-At: > This fixes a bug I ran across today. My sources are from July, > but the bug may be present in the Emacs 25.1 code. Please check. > > diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el > index 58f708a..3d22209 100644 > --- a/lisp/mail/sendmail.el > +++ b/lisp/mail/sendmail.el > @@ -1110,10 +1110,11 @@ mail-combine-fields > (save-restriction > ;; This is just so the screen doesn't change. > (narrow-to-region (point-min) old-max) > - (goto-char old-point) > - (setq query-asked t) > - (if (y-or-n-p (format "Message contains multiple %s fields. Combine? " field)) > - (setq query-answer t)))) > + (save-excursion > + (goto-char old-point) > + (setq query-asked t) > + (if (y-or-n-p (format "Message contains multiple %s fields. Combine? " field)) > + (setq query-answer t))))) The wrapping of y-or-n-p with a save-excursion sounds similar to #2209 "copyright-update might not update copyright", I was thinking it might be a case of a window point being different from the buffer point that causes the unexpected move.