From: Noam Postavsky <npostavs@users.sourceforge.net>
To: rms@gnu.org
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: sendmail.el
Date: Wed, 24 Aug 2016 21:05:43 -0400 [thread overview]
Message-ID: <CAM-tV-_sP04Om=2JQqVNMBrVX_f9DAq1e-6tAtKc5hFjRnPJxQ@mail.gmail.com> (raw)
In-Reply-To: <E1bcOV8-0007Op-9f@fencepost.gnu.org>
> This fixes a bug I ran across today. My sources are from July,
> but the bug may be present in the Emacs 25.1 code. Please check.
>
> diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el
> index 58f708a..3d22209 100644
> --- a/lisp/mail/sendmail.el
> +++ b/lisp/mail/sendmail.el
> @@ -1110,10 +1110,11 @@ mail-combine-fields
> (save-restriction
> ;; This is just so the screen doesn't change.
> (narrow-to-region (point-min) old-max)
> - (goto-char old-point)
> - (setq query-asked t)
> - (if (y-or-n-p (format "Message contains multiple %s fields. Combine? " field))
> - (setq query-answer t))))
> + (save-excursion
> + (goto-char old-point)
> + (setq query-asked t)
> + (if (y-or-n-p (format "Message contains multiple %s fields. Combine? " field))
> + (setq query-answer t)))))
The wrapping of y-or-n-p with a save-excursion sounds similar to #2209
"copyright-update might not update copyright", I was thinking it might
be a case of a window point being different from the buffer point that
causes the unexpected move.
next prev parent reply other threads:[~2016-08-25 1:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 3:05 sendmail.el Richard Stallman
2016-08-24 8:26 ` sendmail.el Nicolas Petton
2016-08-24 19:46 ` sendmail.el Richard Stallman
2016-08-25 1:05 ` Noam Postavsky [this message]
2016-08-25 22:20 ` sendmail.el Richard Stallman
2016-08-27 3:04 ` sendmail.el Noam Postavsky
2016-08-27 7:42 ` sendmail.el Eli Zaretskii
2016-08-27 21:46 ` sendmail.el Richard Stallman
2016-08-27 22:05 ` sendmail.el Noam Postavsky
2016-08-28 2:01 ` sendmail.el John Wiegley
2016-09-03 15:48 ` sendmail.el Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-_sP04Om=2JQqVNMBrVX_f9DAq1e-6tAtKc5hFjRnPJxQ@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).