From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] RFC: eldoc-documentation-functions hook Date: Sun, 17 Jul 2016 11:17:10 -0400 Message-ID: References: <20160612061229.GA6463@holos.localdomain> <838tyahoim.fsf@gnu.org> <20160612182453.GA12034@holos.localdomain> <20160613211735.GA5969@holos.localdomain> <20160617210849.GA3775@holos.localdomain> <20160707033019.GA22360@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1468768665 3720 80.91.229.3 (17 Jul 2016 15:17:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Jul 2016 15:17:45 +0000 (UTC) Cc: Mark Oteiza , Leo Liu , Emacs developers To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 17 17:17:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOnop-0001jD-LG for ged-emacs-devel@m.gmane.org; Sun, 17 Jul 2016 17:17:23 +0200 Original-Received: from localhost ([::1]:41914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOnoo-0003r2-DM for ged-emacs-devel@m.gmane.org; Sun, 17 Jul 2016 11:17:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOnof-0003pT-7p for emacs-devel@gnu.org; Sun, 17 Jul 2016 11:17:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOnod-00038K-DK for emacs-devel@gnu.org; Sun, 17 Jul 2016 11:17:12 -0400 Original-Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:35031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOnod-00038G-8M for emacs-devel@gnu.org; Sun, 17 Jul 2016 11:17:11 -0400 Original-Received: by mail-oi0-x233.google.com with SMTP id l72so77443070oig.2 for ; Sun, 17 Jul 2016 08:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Qpb1qcSu7or6AbEO3YYUTSexBlHkTVzOVt0n1a0ZCCQ=; b=je5VtvKHaLBEnxoPGdJveCC73Fj87i9v3DKt8ntcVLnsFts8a9vSFflZZwg36laJMa Q4sLsR+TliPJdFnI51jAd0t5ViAAxdQt/kxo7rsn26+j2/Xa6MBmHFWiXmSuIovNR2ga piE8YgD0V4MDKy+AJ0HRcJHEW3ex33QdiWHYHfC8U5YIJsQFEhHzIU4MwHjwn/7JwK7m kf7xhj9DTN23WAG8+r6FmDSGmp+dJsvl8FxGpe/fzov3ZvTZ0OjV5T5eIc+xpVTXVJH2 v8HtGa6ytp//xiDh2AXnX/UoQV9riC3klUCZKPYvA8vKZn+LivOr2g5OahG8A+FAI5xj 23NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Qpb1qcSu7or6AbEO3YYUTSexBlHkTVzOVt0n1a0ZCCQ=; b=bPvq6F6U7/P5cwLLFcleo6kk/QEjcH8Yea7QDnOc2km9HVLH3zXsNjJz9n6CzYcK+y eEel1xmWwxigxAMhDXPqSiE2NyNdmRIPQUiDAZXGVyS1EcLwHILvDwVJ0bUrh9JjHUJI 7TJCwnthYd++N2RykAp/IrWvRmcvSElxQoo9lSDA7uQU+kOqrZaLX/y0bYMTzE5cjCVK B+oP+7j72gk2nB+BTwqH2/pcKwUbm3VwydHkhW3iMnMSTBseDq+oeA07Rvd04BbLU7gr usOIm6SkE1wgL3T5sLxpWyfR2uklpoOkcYD4egQTOhbuSNeZldX27OyxsC0NlR31a5rp Xhhg== X-Gm-Message-State: ALyK8tJOAqafKHYYYkYVqx6ontcNvIDs8P4p7Nq0iTjWvP5JjqMDjBVtMtcZQ2rWEAcx7n3cXl8UzytIBC5Uew== X-Received: by 10.157.17.2 with SMTP id g2mr18065323ote.196.1468768630641; Sun, 17 Jul 2016 08:17:10 -0700 (PDT) Original-Received: by 10.157.7.161 with HTTP; Sun, 17 Jul 2016 08:17:10 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: MxXZLST2TiZsZ4uKUYTzVFtkA7Q X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205778 Archived-At: On Thu, Jul 7, 2016 at 6:02 AM, Kaushal Modi wrote: > I'm neither for or against this change. But if this change is done in > eldoc.el, then shouldn't the add-function to add-hook change be done in all > the major modes too? Like in elisp-mode.el, etc. > Ping! I just bumped into this elisp-mode.el case while playing with the bootstrap. Please revert this, or fix callers, thanks.