From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: moving some indentation tests Date: Sun, 2 Apr 2017 17:02:45 -0400 Message-ID: References: <878tnj2lap.fsf@tromey.com> <874ly6ft50.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1491167003 28531 195.159.176.226 (2 Apr 2017 21:03:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Apr 2017 21:03:23 +0000 (UTC) Cc: Tom Tromey , Emacs discussions To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 02 23:03:19 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cumea-0006Z0-2c for ged-emacs-devel@m.gmane.org; Sun, 02 Apr 2017 23:03:16 +0200 Original-Received: from localhost ([::1]:56261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cumef-0004E6-UQ for ged-emacs-devel@m.gmane.org; Sun, 02 Apr 2017 17:03:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cume7-0004Dp-IE for emacs-devel@gnu.org; Sun, 02 Apr 2017 17:02:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cume6-0005wY-Qs for emacs-devel@gnu.org; Sun, 02 Apr 2017 17:02:47 -0400 Original-Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]:33353) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cume6-0005vm-NA for emacs-devel@gnu.org; Sun, 02 Apr 2017 17:02:46 -0400 Original-Received: by mail-oi0-x22e.google.com with SMTP id b187so106993571oif.0 for ; Sun, 02 Apr 2017 14:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=MI63xnyxaUXYI+NfwwB0RF86mgCRNfrbnrjbb25y91s=; b=V1tlBnF0KkKwGTiEZEMYYBY8h2nSjoOFBQIXaJifQ8TcezmV1g2o8RbUBMYm1u5OQP TJsiS+Y3Aj8tgsQ1igD4pabMcYHHlsn2yH5zZZIg/+dRgdaIzH5/WvYI7BOT6AWB3UEj Yg1OkGbJJOdL02Uudb5Jg9X56cL5qM29XY3CKZm+heSOMqLx4ilIF5ZXiD2tjMLeNhkL eTtJFBpKJgp5xjkmrWVL7kjqFln3mrj849/NvT8jUUwMw77vDaYjES2YIpeMt1yEMjcA UUq4NTzdiEpl35UWK741koNkgxVnEwLnguguxL30qsfOgS3QUFFuRQcgklBd/5js8wIp JllQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=MI63xnyxaUXYI+NfwwB0RF86mgCRNfrbnrjbb25y91s=; b=SwrRMjQ7Mn5+2wCu+NsUN9ZGRNGLgzPVXoJK2ZRo/Z7rSEkARTlXG2iPUokAbzqxXq 1gNw446zywr7mjJPGVQtUjuLI0QUuMu1sCVEeeEq2df2o2Etd3qtoDTTvD62ZzemvkV7 P+fOrLkrFzMVzA3UhldvvGe+FF1FSHKx6Hprrb1M3H7zXkYzwK3u8pnt0n/Ss+iisSaP kAz1W2qgcQGEfhSyCoK0ikWe8GCXds7fBqjANgEaidGx+oZVQ0pcbcNjBdlAmzJw/5u+ 4jssJJrUwsFe4eTgUNBjRhM0bLbboXLizD0i590E0gvxB2yAD/Vli677bvVn26Zqg1ov BVrw== X-Gm-Message-State: AFeK/H2eywndXs9Dd3EaAcUp6bNkMLGRvIMAIhU5n/Ie5WcFItd2GrcM2WPOwqOcfUNfkHDFMC+e7o5E0T0c8Q== X-Received: by 10.157.68.237 with SMTP id p45mr8284069otg.244.1491166965751; Sun, 02 Apr 2017 14:02:45 -0700 (PDT) Original-Received: by 10.157.80.133 with HTTP; Sun, 2 Apr 2017 14:02:45 -0700 (PDT) In-Reply-To: <874ly6ft50.fsf@russet.org.uk> X-Google-Sender-Auth: 1qKjXcg0r_0pb3qdQKc1QTcrp90 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213602 Archived-At: On Sun, Apr 2, 2017 at 4:31 PM, Phillip Lord wrote: > > My own package, assess, provides good support for this kind of > functionality. In particular, you can do this: > > > (assess-roundtrip-indentation= > 'emacs-lisp-mode > " > (assess-with-find-file > \"~/.emacs\" > (buffer-string))") For indent-sexp tests I just wrote this sort of thing in line (see test/lisp/emacs-lisp/lisp-mode-tests.el). Would have been handy to have some pre-written functions for it. After a quick glance I think there are two issues that would get in the way of using the code currently in assess for those tests though (ignoring the non-Emacs deps). I found that adding indentation and then reindenting turned up some different bugs than removing indentation and reindenting. It looks like assess only does the latter right now. Also, AFAICT, it doesn't preserve indentation inside multi-line string literals.