From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Mon, 7 Nov 2016 20:12:50 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1478567631 31037 195.159.176.226 (8 Nov 2016 01:13:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Nov 2016 01:13:51 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 08 02:13:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3uya-0004Z0-2E for ged-emacs-devel@m.gmane.org; Tue, 08 Nov 2016 02:13:24 +0100 Original-Received: from localhost ([::1]:57587 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3uyd-0003Kn-2B for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 20:13:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3uy5-0003KX-E5 for emacs-devel@gnu.org; Mon, 07 Nov 2016 20:12:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3uy4-0001RG-FA for emacs-devel@gnu.org; Mon, 07 Nov 2016 20:12:53 -0500 Original-Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]:36443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3uy4-0001Qy-9c for emacs-devel@gnu.org; Mon, 07 Nov 2016 20:12:52 -0500 Original-Received: by mail-it0-x22b.google.com with SMTP id q124so62838480itd.1 for ; Mon, 07 Nov 2016 17:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gZp3GhFGbjRiQOqy5rD3zyf2TBQLORh2XZfX/H8hKls=; b=nRJSQSJu902Zu5qTQg+4uqMCtrsTi3zG2yzx3z5pWzzq4pjApGtZ8OOYKrcNvtPIN+ rHLNhTTJ+aDxM2S7/gQl+pLgqgc/ILcO61mbSiAgXgXS6K/NEqkYPITSZwKWb7y3/FnG UAEbQoQs5ZnG6fQuss5uDPpjCQvFYEDZjQmXH7YLaD0I8SazKYbNZUzYZXGs784WGC0q scz1LH48Baw6Qi5yXRuAqNY84fmZegJcpVKlC4HGrjWxAH1O5pHI/Oio//s3R27Xdul8 aqwfNJRLdcvY1SLHQ/zvqbb63WrRt984gh91RQyzmXb1uuFwCpK6OS+NcWb8KbjCWZnV 41Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gZp3GhFGbjRiQOqy5rD3zyf2TBQLORh2XZfX/H8hKls=; b=G7gIoypFj3G/17DS33Xo+kRJOnha2Pq9cp7OsMLEI5sfiMhqMxlEVSGSuPGl7lmoAE lQ1D0mUH8RegZ2eUxkhk86sIF4KSxRaKn5/YOlskK5FPymM3GRQl7hOnVn2CrZvQJPpz 4XPvNDxvS7zGYvriUJ4mE6pn5JxUkDGywheob3BkypaO37eT2ylKfVUrKaOWgrBNwfyO qPKUnsODJS+SLN/NJIQ55mkSQPTLQgDO/sg1cB6qkYEGk3ckmpFTd9KSSzVo0OBPdsy+ 8k22FUJEhEJPS/YGcczL8Agres1zEQTzrMfJHXghcRooXW8X8xxz/RA/sx6sccCGFgTn Juag== X-Gm-Message-State: ABUngvc0Ar/lx2OuFmMltYcyW7Fct2gMC1lFGwK97HtFT8Ix0DL3uSHkPngcipZnzEbFdEdRmM/QFBnrK2NNeA== X-Received: by 10.157.15.176 with SMTP id d45mr3878664otd.169.1478567571233; Mon, 07 Nov 2016 17:12:51 -0800 (PST) Original-Received: by 10.157.4.86 with HTTP; Mon, 7 Nov 2016 17:12:50 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c0b::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209274 Archived-At: On Sun, Nov 6, 2016 at 5:47 PM, Stefan Monnier wrote: > >> I don't quite understand what's the benefit of calling debug when >> debug-on-error is non-nil: signalling the error is going to call it >> anyway. > > Not if the code is run within an `ignore-errors` clause or some other > condition-case catching `error`. Hmm, this seems like kind of a kludgy way to circumvent ignore-errors. Wouldn't it better to use (setq debug-on-error '(cl-assertion-failed) debug-on-signal t) along with: (defun cl--assertion-failed (form &optional string sargs args) (signal 'cl-assertion-failed (if string (apply #'format-message string (append sargs args)) `(,form ,@sargs))))