From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695). Date: Wed, 15 Jun 2016 23:04:27 -0400 Message-ID: References: <20160614214332.2901.16184@vcs.savannah.gnu.org> <20160614214332.C030F220116@vcs.savannah.gnu.org> <87h9cuyeip.fsf@gmx.net> <87d1nixzcu.fsf@gmx.net> <83ziqmcwe8.fsf@gnu.org> <874m8ucoh5.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1466046285 15773 80.91.229.3 (16 Jun 2016 03:04:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jun 2016 03:04:45 +0000 (UTC) Cc: Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 16 05:04:44 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDNbl-0008UY-Rr for ged-emacs-devel@m.gmane.org; Thu, 16 Jun 2016 05:04:42 +0200 Original-Received: from localhost ([::1]:46104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDNbl-00083G-4s for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 23:04:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDNbf-00082v-Vm for emacs-devel@gnu.org; Wed, 15 Jun 2016 23:04:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDNbf-0004tb-1w for emacs-devel@gnu.org; Wed, 15 Jun 2016 23:04:35 -0400 Original-Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:34498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDNbc-0004rq-Ak; Wed, 15 Jun 2016 23:04:32 -0400 Original-Received: by mail-oi0-x22c.google.com with SMTP id d132so49619574oig.1; Wed, 15 Jun 2016 20:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=m5spnTWpYI3Zxp2Lb7xvITNHFyQuhZer2F70ZLeclbc=; b=de06YCoNpMyPo5dx5m5HbyyLAjxaWzgAsRF8G1jRx39ZEWdJc59sOKrYeY9tdI/t5y OpGJjOcJOEbYjgI6M1KpKoioZYuktCTj8U3Kr+23RWJamiK/x8pW3FvmX0Ne2w+3KJe+ n+Eb5PPX5KzPTYUEEOT0wLh1YEy2mxRvg88SSGK4ckZbsN32UAVWGqnhhLAc7ZYEk5Np XGltw69iQYPGz27EmGpxgl5gf83ZtNlYV1YbGnzn+wq4MAnrj1UICiCaA18DwexhEjx0 EFeh9np61FJUwjhBr/zNx8wAKJJzF4P3/o5OGcZHKS6G6QHcup6TaoJSVz7lb3YKzRQ6 hEQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=m5spnTWpYI3Zxp2Lb7xvITNHFyQuhZer2F70ZLeclbc=; b=iGFE5JpEEezuY4aTIsNa6JjWfTPPrGJM824Bl1eRgVfyxWqBcq6AbFSaULMo/hlzN5 o+F3X6JHF4aFw7figDkyBykFb5LjSiMc4g+pY66zyVh+DJ9J300mPeasrzVYj+BtC+wL O9llq+Jv6lgU9+AD0/J42isGZiJ/GdN77UZzHfp+8LBlP4SN1/M8l2Kv0Ex1gO8Ltk7U Q9AT+SPkd1IdT/J4qV4b6qPlaUthvTGY6mUOG27LvHeFnK5pekV1QES8ChEHzePAp+aM Yh0kuQfV4oepA3KLT/Yp3H1RKbYYp0UWHHS0BMNwjeMhIfs6gZDmWq7/zOhguKkStVp7 6W9A== X-Gm-Message-State: ALyK8tLoCe4oFjq3M2G2Ib0FsHHn3GpPGCWZPa3BBkeFMvb0MU28jaMu1zMx+xc3LAyRCjTa+Je8oUCMeZcjtA== X-Received: by 10.157.49.119 with SMTP id v52mr1217150otd.134.1466046271746; Wed, 15 Jun 2016 20:04:31 -0700 (PDT) Original-Received: by 10.157.44.103 with HTTP; Wed, 15 Jun 2016 20:04:27 -0700 (PDT) In-Reply-To: <874m8ucoh5.fsf@gmx.net> X-Google-Sender-Auth: gxBbB2nIXQJLJnywW5mZQPZqCQ0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204425 Archived-At: On Wed, Jun 15, 2016 at 2:10 PM, Stephen Berman wrote: > > Thanks, done as commit 5d4d8a3. I think it does nothing but bind minibuffer-local-completion-map to nil, since define-key doesn't return the map. You should have (let ((minibuffer-local-completion-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-completion-map) (define-key map " " nil) map))) ; <---------- use the map ...