From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 425c281 1/3: Allow t as a catch-all condition-case handler (Bug#24618) Date: Wed, 5 Sep 2018 10:38:11 -0400 Message-ID: References: <20180904230314.12505.44942@vcs0.savannah.gnu.org> <20180904230315.6EB44209DC@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1536158180 4373 195.159.176.226 (5 Sep 2018 14:36:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Sep 2018 14:36:20 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 16:36:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxYug-0000tm-V4 for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 16:36:11 +0200 Original-Received: from localhost ([::1]:56553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxYwn-0002MI-Be for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 10:38:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxYwg-0002Lw-AR for emacs-devel@gnu.org; Wed, 05 Sep 2018 10:38:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxYwf-0003jb-Jm for emacs-devel@gnu.org; Wed, 05 Sep 2018 10:38:14 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:44961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxYwf-0003iV-Dm for emacs-devel@gnu.org; Wed, 05 Sep 2018 10:38:13 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id l82-v6so13985734oih.11 for ; Wed, 05 Sep 2018 07:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=USdkjis5uYNbVlg1sJePN35hr3QTHZxiWlkBbIoHVsk=; b=AdaO3vn6NosVWYQ7r25gVScRawEGbwGtnSExt40TzaOK+3UI+pSYC01aAdL7PnuGTL lnwUba6KmEbj6ddVVH40kLqNAaRTnZM5yyb2Th91ChkY+4qDcuwal/nMJusJW5BXnj5B +4o+c2InRyl/jaPUyRlB58j2WlLr12jmivv2pms/YscNNgYVyotMqhrtX4dZqmw98Wbm 0K4ex6GblB9q5T1nlFByI1hx1TARmhr7Mg4UzLDrD1/ZcVQ5GdNslvm7kWQbXvBJMpI4 QgCKMchgSy27z85oOqCEEucwepynBd4NwogvMnfhgnq1fsHE7xjitp+LO1PRfXum9ta8 +z6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=USdkjis5uYNbVlg1sJePN35hr3QTHZxiWlkBbIoHVsk=; b=SrnSc86TE82LU6U6Fue/JzThNcuUrtN9c73hYI1++vqwHuQMYaok9qnhFw3NX2185Y hFZkcnNV1tJ7mEM79jfieB0zPaeJtcj1PNA7sgAVlXaf4ZPLcZ6HelqBzBe9DzUC2afz E04ELw/vGE3hgUB1xLWdpXg8d7pmfF11qfapnzjLaVGSu7JwgyzozJQQ9Ap/AqRIXMDQ +m/eg5lHphY88OJf+kHd6d+LZ10ahOIjwkKZjWg5LJnjFwQHZb9zlX0D1IGUOlO031JE 3UQodMiG6rwDwbDVug4WzpxxgvzG81zbmVYz5KbDD0DOUr41NjxjgIPbLs4lY5RwWsWO dP0w== X-Gm-Message-State: APzg51CvIdnw8pn5EsNy0HdyPbz1//YzXgUNhZVr58E0fExqEjMEcMyX oxeV9PyJRHPg1GdcWvQbDh65O25RRl2xCRQw79o= X-Google-Smtp-Source: ANB0VdYtLMKK+h2I7+CuUirprMc+GMPh6YefkSOYgsWbaopaDd4BDx4h0JRMqv81K2uIWN4xTjoC0vUxZqtkXKKMHEs= X-Received: by 2002:aca:506:: with SMTP id 6-v6mr31465147oif.23.1536158292792; Wed, 05 Sep 2018 07:38:12 -0700 (PDT) Original-Received: by 2002:a9d:540f:0:0:0:0:0 with HTTP; Wed, 5 Sep 2018 07:38:11 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229292 Archived-At: On 4 September 2018 at 22:46, Stefan Monnier wrote: >> +A CONDITION-NAME of t applies to any error symbol. > > All error symbols are caught by `error` already. Those extra conditions > caught by `t` are non-error conditions Hmm, right. The rest of the docstring talks only about errors though. Should we change the whole thing? While technically more accurate, saying "Regain control when a signal is signaled" sounds a bit funny. Otherwise, fixing just that sentence: A handler is applicable to an error if CONDITION-NAME is one of the -error's condition names. A CONDITION-NAME of t applies to any error -symbol. If an error happens, the first applicable handler is run. +error's condition names. A CONDITION-NAME of t applies to any condition +name. If an error happens, the first applicable handler is run. > (the only one I know of is `quit`, BTW). That, and possible silly code which does something like: (signal 'not-an-error-symbol "oops")