Re: Fix to handling of C++ digit separators, improvements in handling of single quotes.

[Noam Postavsky <npostavs@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Sat, Jul 1, 2017 at 12:10 PM, Alan Mackenzie <acm@muc.de> wrote:
> The code involved is moderately involved, with special cases needed to
> handle things like '\'', '\\', or char foo [] = {',',',',',',','};.  So
> if there are any problems with it (in particular, large areas of text
> following a quotey bit getting misfontified with font-lock-string-face),
> please let me know.

I think this change breaks tests/lisp/electric-tests.el, here's a
reduced test case (backtrace attached)

(with-temp-buffer
  (c++-mode)
  (insert " (((()) ")
  (goto-char 4)
  (insert ")"))

[-- Attachment #2: c-quotes.backtrace --]
[-- Type: application/octet-stream, Size: 1619 bytes --]

Debugger entered--Lisp error: (args-out-of-range 0 0)
  get-text-property(0 syntax-table)
  c-clear-char-property-with-value-on-char-function(0 4 syntax-table (1) 39)
  c-parse-quotes-before-change(4 4)
  #f(compiled-function (fn) #<bytecode>)(c-parse-quotes-before-change)
  mapc(#f(compiled-function (fn) #<bytecode>) (c-extend-region-for-CPP c-before-change-check-raw-strings c-before-change-check-<>-operators c-depropertize-CPP c-invalidate-macro-cache c-truncate-bs-cache c-parse-quotes-before-change))
  c-before-change(4 4)
  insert(")")
  (progn (c++-mode) (insert " (((()) ") (goto-char 4) (insert ")"))
  (unwind-protect (progn (c++-mode) (insert " (((()) ") (goto-char 4) (insert ")")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (c++-mode) (insert " (((()) ") (goto-char 4) (insert ")")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (c++-mode) (insert " (((()) ") (goto-char 4) (insert ")")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
  eval((let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (c++-mode) (insert " (((()) ") (goto-char 4) (insert ")")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) nil)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)