* Re: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)
[not found] ` <20161203014505.D8E2D2201C6@vcs.savannah.gnu.org>
@ 2016-12-09 15:10 ` Stefan Monnier
2016-12-17 14:31 ` Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)) Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2016-12-09 15:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Noam Postavsky
> + else if (sym->redirect == SYMBOL_LOCALIZED
> + && SYMBOL_BLV (sym)->frame_local)
> + xsignal1 (Qtrapping_frame_local, symbol);
BTW, make-variable-frame-local has been declared obsolete since
Emacs-22.2, so I think now is a good time to get rid of
frame-local variables.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923))
2016-12-09 15:10 ` [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923) Stefan Monnier
@ 2016-12-17 14:31 ` Stefan Monnier
2016-12-17 14:59 ` Noam Postavsky
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2016-12-17 14:31 UTC (permalink / raw)
To: emacs-devel
Ping?
I'll take care of the patch, if we agree,
Stefan
>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + else if (sym->redirect == SYMBOL_LOCALIZED
>> + && SYMBOL_BLV (sym)->frame_local)
>> + xsignal1 (Qtrapping_frame_local, symbol);
> BTW, make-variable-frame-local has been declared obsolete since
> Emacs-22.2, so I think now is a good time to get rid of
> frame-local variables.
> Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923))
2016-12-17 14:31 ` Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)) Stefan Monnier
@ 2016-12-17 14:59 ` Noam Postavsky
2016-12-21 19:27 ` Killing frame-locals Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2016-12-17 14:59 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Emacs developers
On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> Ping?
>
> I'll take care of the patch, if we agree,
>
>
> Stefan
>
>
>>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> + else if (sym->redirect == SYMBOL_LOCALIZED
>>> + && SYMBOL_BLV (sym)->frame_local)
>>> + xsignal1 (Qtrapping_frame_local, symbol);
>
>> BTW, make-variable-frame-local has been declared obsolete since
>> Emacs-22.2, so I think now is a good time to get rid of
>> frame-local variables.
>
I did a web search for make-variable-frame-local, I found only
perspective-el still using it. I think it's a fairly popular package;
on the other hand, it's not in GNU ELPA, and it's not like they didn't
have warning in advance...
https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197
;; make-variable-frame-local is obsolete according to the docs,
;; but I don't want to have to manually munge frame-parameters
;; all the time so I'm using it anyway.
(make-variable-frame-local
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Killing frame-locals
2016-12-17 14:59 ` Noam Postavsky
@ 2016-12-21 19:27 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2016-12-21 19:27 UTC (permalink / raw)
To: emacs-devel
OK, looks like there's no objection, so I'll install the patch.
Thanks,
Stefan
>>>>> "Noam" == Noam Postavsky <npostavs@users.sourceforge.net> writes:
> On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier
> <monnier@iro.umontreal.ca> wrote:
>> Ping?
>>
>> I'll take care of the patch, if we agree,
>>
>>
>> Stefan
>>
>>
>>>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>>> + else if (sym->redirect == SYMBOL_LOCALIZED
>>>> + && SYMBOL_BLV (sym)->frame_local)
>>>> + xsignal1 (Qtrapping_frame_local, symbol);
>>
>>> BTW, make-variable-frame-local has been declared obsolete since
>>> Emacs-22.2, so I think now is a good time to get rid of
>>> frame-local variables.
>>
> I did a web search for make-variable-frame-local, I found only
> perspective-el still using it. I think it's a fairly popular package;
> on the other hand, it's not in GNU ELPA, and it's not like they didn't
> have warning in advance...
> https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197
> ;; make-variable-frame-local is obsolete according to the docs,
> ;; but I don't want to have to manually munge frame-parameters
> ;; all the time so I'm using it anyway.
> (make-variable-frame-local
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-21 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161203014504.8507.42564@vcs.savannah.gnu.org>
[not found] ` <20161203014505.D8E2D2201C6@vcs.savannah.gnu.org>
2016-12-09 15:10 ` [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923) Stefan Monnier
2016-12-17 14:31 ` Killing frame-locals (was: [Emacs-diffs] master 88fefc3 7/7: ; Merge: Lisp watchpoints (Bug#24923)) Stefan Monnier
2016-12-17 14:59 ` Noam Postavsky
2016-12-21 19:27 ` Killing frame-locals Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).