From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: replacing ldefs-boot.el Date: Sat, 26 Nov 2016 00:34:34 -0500 Message-ID: References: <87bmxa6o37.fsf@russet.org.uk> <83y40e7y65.fsf@gnu.org> <87twb16dta.fsf@russet.org.uk> <83vavh8qci.fsf@gnu.org> <87a8csij8c.fsf@russet.org.uk> <87eg1zmdd7.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1480138488 23265 195.159.176.226 (26 Nov 2016 05:34:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 26 Nov 2016 05:34:48 +0000 (UTC) Cc: Eli Zaretskii , Emacs developers To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 26 06:34:44 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAVdL-00058u-QV for ged-emacs-devel@m.gmane.org; Sat, 26 Nov 2016 06:34:43 +0100 Original-Received: from localhost ([::1]:49220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAVdP-0005cZ-Gb for ged-emacs-devel@m.gmane.org; Sat, 26 Nov 2016 00:34:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAVdG-0005cI-Cn for emacs-devel@gnu.org; Sat, 26 Nov 2016 00:34:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAVdF-0002SG-FR for emacs-devel@gnu.org; Sat, 26 Nov 2016 00:34:38 -0500 Original-Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:35613) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cAVdD-0002Rg-Tl; Sat, 26 Nov 2016 00:34:35 -0500 Original-Received: by mail-oi0-x22f.google.com with SMTP id b126so99992056oia.2; Fri, 25 Nov 2016 21:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iqGoSqVUwfHilmEzDUOxmZrLHj36Ocyl3q8XjqMMtRI=; b=b4w/a0mxpOY9knUksi/HCY7kCEXGi8KzpxrhIdG4WszsheiLKrT90T4+G2ObiGXzPx 9J0yy0zuCXxFS4wLLFg0WEUczhUDYg8rOzPfVFlMhzkDeBaKoz+VLKPKka65/D52+8kn c8gvJGov1EnOCGpXSlRbtXJ7c9m8h+yPJlGvhw/Yyo7+cimVnNSxk4+pgRllWhQRc32Z NO03hP+gqwg8gQdd7ploVhoxK0p4Rb4BXPvmxBvTbSY1LpVWKkuPCQB/7p8WjEur4K3B MYxZVELgOa72kdM52gTDstvfMqDc0dl2A6Z5HN8MOnO/RwImjDdXVMSEd082BfVa1lfw S1rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iqGoSqVUwfHilmEzDUOxmZrLHj36Ocyl3q8XjqMMtRI=; b=bHjTBg8ZzpA6XNw6hPx/jNkxJwy82WWvsVq/HethjzFghjQAz3Ei+3mUnd1MPPLQ/E CvHy2PB9uqUEOsr6QsrKmPZ1uTyRwIASma+Ji+w1njUlt1m+BoyEmH8G7VOmqNStbeNY afMcF159XDpO8LxlLwVgmLQCGcYDIsdY64UFvt1CB/x+xrskPzEUdXEljYXgQrBsU4xL RtbbGGszCpGOhlU2lXl6vyDX7zK8K5kBkAzj01QLRTZ+nBJv++cF6scBlyllWCIbrfHU bETa0QYF8vUWN2+hSN+vholy24+d5Z6mSyYNR6+f2Wyhn/tZ744oqVJ3gfiHeQQJRh0B 72uw== X-Gm-Message-State: AKaTC03VRKeBIqa3LVsbN/E/TV0TZwlqAqtyNxxxKRfFBTRz7C66fNbnAOhxBdNMiwMA5XpwpVGO1W7ylfLKcA== X-Received: by 10.157.54.245 with SMTP id s50mr6452564otd.181.1480138474914; Fri, 25 Nov 2016 21:34:34 -0800 (PST) Original-Received: by 10.157.4.67 with HTTP; Fri, 25 Nov 2016 21:34:34 -0800 (PST) In-Reply-To: <87eg1zmdd7.fsf@russet.org.uk> X-Google-Sender-Auth: YfW0a4L1tGOdqEWBf3bVqSY9WTA X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209601 Archived-At: On Fri, Nov 25, 2016 at 4:57 PM, Phillip Lord wrote: > Noam Postavsky writes: >>> Disadvantages: >>> >>> - generating ldefs-boot-auto is a lot slower (i.e. cp loaddefs.el >>> ldefs-boot.el vs a complete bootstrap build of Emacs). >>> >> >> Is it possible another disadvantage would be that ldefs-boot-auto >> requires regeneration more often (because the list of autoloads used >> is more precise)? > > > No, I don't think that this is the case. ldefs-boot.el is actually > regenerated regularly IIUC (I think Glenn does it on a cron job; or he > gets up specially at 6am on the first of every month). And it changes > each time since it reflects changes in any autoloads any where in Emacs > (nearly), including things like documentation changes. Oh, I didn't notice the frequency, I somehow had the impression it just done as needed. > > I have no idea what percentage of those commits are actually necessary > -- the unfortunate reality is that you can only test this with a full > bootstrap build which is something that most developers do rarely. My guess is that with the smaller ldefs-boot-auto it will be necessary more often. But maybe not enough to matter, hard to say. > > >> I notice several almost duplicated lines in ldefs-boot-auto.el, like >> >> (autoload 'byte-compile "bytecomp" nil nil nil) >> (autoload 'byte-compile "bytecomp" nil nil t) >> >> byte-compile isn't a macro; I think you should put your addition to >> Fautoload_do_load after the "if (EQ (macro_only, Qmacro))" check to >> avoid falsely identifying macros. > > Yeah, that's a screw up, thanks for picking this up. > > I don't understand the semantics of the macro_only parameter, at all, > nor what that if statement is doing, but I'll try this fix. I think the value of FUNDEF tells you whether it's a macro, the macro_only parameter just says to do nothing for non-macros. > >> And doesn't this change in Makefile.in break parallel 'make bootstrap' >> invocations? >> >> -bootstrap: bootstrap-clean >> +bootstrap: bootstrap-clean bootstrap-build >> + >> +bootstrap-build: > > Does it? bootstrap-clean and bootstrap-build cannot be run in parallel > anyway. Right. And I think the definitions you put would let make run them in parallel, thus breaking things.