unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Herwig Hochleitner <hhochleitner@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Segfault during fontification of rgrep buffers [HELP NEEDED]
Date: Wed, 26 Oct 2016 15:25:27 -0400	[thread overview]
Message-ID: <CAM-tV-9hrv6qcXJK5i+T=AQ=HiKVJNSUW2Dp4EmBY_Y2ydkcJw@mail.gmail.com> (raw)
In-Reply-To: <CADUC9hpVoaoXxB3oRRt=y=OCSNdk_8p_LKVCJMQpb0RczKjztA@mail.gmail.com>

On Wed, Oct 26, 2016 at 2:44 PM, Herwig Hochleitner
<hhochleitner@gmail.com> wrote:
> 2016-10-26 20:36 GMT+02:00 Noam Postavsky <npostavs@users.sourceforge.net>:
>>
>> On Wed, Oct 26, 2016 at 12:09 PM, Herwig Hochleitner
>> <hhochleitner@gmail.com> wrote:
>> > Hi,
>> >
>> > I've been hunting a segfault during usage of rgrep for some time, now
>> > I've
>> > managed to catch it in gdb. From the looks of it, BEGV_ADDR is changed
>> > during a single run of search_buffer, which leaves a stale pointer in a
>> > local variable.
>>
>>
>> This is almost certainly the same bug as #24358. You can try building
>> with REL_ALLOC=no, or applying
>>
>> https://debbugs.gnu.org/cgi/bugreport.cgi?msg=225;att=2;bug=24358;filename=v4-0002-Inhibit-buffer-relocation-during-regex-searches.patch.
>
>
> That looks like the issue. I'll do a test build, and if successful, will add
> the patch to NixOS' emacs 25.1 build.
>
> Thanks!

Actually, there are a few other similar issues in other parts of the
code, so you should to apply all of

http://git.savannah.gnu.org/cgit/emacs.git/patch/?id=71ca4f6a43bad06192cbc4bb8c7a2d69c179b7b0
http://git.savannah.gnu.org/cgit/emacs.git/patch/?id=1047496722a58ef5b736dae64d32adeb58c5055c
http://git.savannah.gnu.org/cgit/emacs.git/patch/?id=96ac0c3ebce825e60595794f99e703ec8302e240
http://git.savannah.gnu.org/cgit/emacs.git/patch/?id=43986d16fb6ad78a627250e14570ea70bdb1f23a

(that last one is the same as what I told you earlier). Certainly just
using REL_ALLOC=no is simpler, but getting confirmation that the
patches work would be useful also.



  reply	other threads:[~2016-10-26 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 16:09 Segfault during fontification of rgrep buffers [HELP NEEDED] Herwig Hochleitner
2016-10-26 18:36 ` Noam Postavsky
2016-10-26 18:44   ` Herwig Hochleitner
2016-10-26 19:25     ` Noam Postavsky [this message]
2016-10-27 23:08       ` Noam Postavsky
2016-11-10  4:47         ` Herwig Hochleitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM-tV-9hrv6qcXJK5i+T=AQ=HiKVJNSUW2Dp4EmBY_Y2ydkcJw@mail.gmail.com' \
    --to=npostavs@users.sourceforge.net \
    --cc=emacs-devel@gnu.org \
    --cc=hhochleitner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).