From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Odd block highlighting [master build] Date: Tue, 20 Sep 2016 17:48:59 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1474408189 26166 195.159.176.226 (20 Sep 2016 21:49:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Sep 2016 21:49:49 +0000 (UTC) Cc: John Mastro , Emacs developers , wsnyder@wsnyder.org To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 20 23:49:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmSv4-0005dC-Pf for ged-emacs-devel@m.gmane.org; Tue, 20 Sep 2016 23:49:38 +0200 Original-Received: from localhost ([::1]:38395 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmSv3-0000cO-1w for ged-emacs-devel@m.gmane.org; Tue, 20 Sep 2016 17:49:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmSuT-0000cJ-Tf for emacs-devel@gnu.org; Tue, 20 Sep 2016 17:49:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmSuS-0007Is-Vc for emacs-devel@gnu.org; Tue, 20 Sep 2016 17:49:01 -0400 Original-Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:33754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmSuS-0007Ih-Qo for emacs-devel@gnu.org; Tue, 20 Sep 2016 17:49:00 -0400 Original-Received: by mail-oi0-x22f.google.com with SMTP id r126so38655805oib.0 for ; Tue, 20 Sep 2016 14:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6WEE9HfPx8cOAb13KFe0dt5wfHhsN8XEz+8rTf2ZMHU=; b=dCB+NmruwQfpJVWPpxIQE9vCdUZtfX2r9aWl7F9w13PQ5piLa5DVYHcjMg4UXufZuf d3y2DanjDin24jNEcihuQeeBcdOI1FwI55oF2/1QsDHsPzMgz02xhO6J97+wrfKlh1+c KseaalSAPXpKWcdtaATuXLOLTi++pleE8ZN2g+kHIqdADMF+owWE8yXbpHmFUUa4g5QO ob3qk/LP8A2RxPL/u6KIpexarOF3ZZoy4ujKQCJKlbB6aaqoTc614XSmnZThsJU3Fjvn T9/3Qt74kaU/4FuQ/dc06cUgkH3u1BDRDxHSCgZTwA6zRphHuVg8oHxRhEpSUx0dKI2S enww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6WEE9HfPx8cOAb13KFe0dt5wfHhsN8XEz+8rTf2ZMHU=; b=Hg03Ijw9frds4QAmuJUVWGsmGUU3B6KjfTXEOtYUUDnz7kPoYFTplTuFXJC0T334pY A77K8ZG+s1wU+yWW0312gJJheSpP6qNQcdrwHGCky754mEj1pBjFa2nLKqOA4KeB5CXX KdsXz8IwrbIOeCDKxE+dr5Kxm/N6An63lhBsG6uo/QGLNzikJLTGrMVib8YM1XbyBV2J 8Udg3d9opzNQ6RxHSP/5lqR9dyTh48kjOthDfqJJOz3B5kMBtUNnVmn0p0/JPFKTSMq9 qADFFwsKxI0ehR+iZohifxzgpcI7F42GRu4XGnK6er6JPpjeIIeiaQRkYmfj0l+JbHsS aynw== X-Gm-Message-State: AE9vXwPgxoXWPjOFv0qbOqTVWHqg0YGs+vSNt1WM9pT5EQLYS1KwSmdrwFf+o70c5t/w0MIZrmUN7Q4hbRr2JQ== X-Received: by 10.202.78.131 with SMTP id c125mr36251823oib.158.1474408140268; Tue, 20 Sep 2016 14:49:00 -0700 (PDT) Original-Received: by 10.157.41.144 with HTTP; Tue, 20 Sep 2016 14:48:59 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: Vb12XNdTtk3ZTRuPKI0l1tx1z0s X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207646 Archived-At: On Tue, Sep 20, 2016 at 4:53 PM, Kaushal Modi wrote: > > It looks like the verilog-highlight-region is causing this: > > These highlight overlays are added via a couple of hooks: > > (add-hook 'font-lock-mode-hook 'verilog-highlight-buffer t t) > (add-hook 'font-lock-after-fontify-buffer-hook 'verilog-highlight-buffer > t t) ; not in Emacs > (add-hook 'after-change-functions 'verilog-highlight-region t t) > > @Noam: A wild guess.. would this commit > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=66f95e0dabf750e9d2eff59b2bb6e593618cd48a > be related in any way to what we are seeing here? It shouldn't affect this, it should only stop after-change-functions members (like verilog-highlight-region) from messing up match data when they call save-match-data.