unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: John Mastro <john.b.mastro@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>,
	wsnyder@wsnyder.org
Subject: Re: Odd block highlighting [master build]
Date: Tue, 20 Sep 2016 17:48:59 -0400	[thread overview]
Message-ID: <CAM-tV-9fPerHKwwnWWPuzBT6zkaZekFLKcp1j=GEto74e8BgwQ@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY3MEdnzqkXD6M0CWzuqhkjCE+ncB6bXx3OQOB2rO2eXew@mail.gmail.com>

On Tue, Sep 20, 2016 at 4:53 PM, Kaushal Modi <kaushal.modi@gmail.com> wrote:
>
> It looks like the verilog-highlight-region is causing this:
>
> These highlight overlays are added via a couple of hooks:
>
>     (add-hook 'font-lock-mode-hook 'verilog-highlight-buffer t t)
>     (add-hook 'font-lock-after-fontify-buffer-hook 'verilog-highlight-buffer
> t t) ; not in Emacs
>     (add-hook 'after-change-functions 'verilog-highlight-region t t)
>
> @Noam: A wild guess.. would this commit
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=66f95e0dabf750e9d2eff59b2bb6e593618cd48a
> be related in any way to what we are seeing here?

It shouldn't affect this, it should only stop after-change-functions
members (like verilog-highlight-region) from messing up match data
when they call save-match-data.



  reply	other threads:[~2016-09-20 21:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 18:44 Odd block highlighting [master build] Kaushal Modi
2016-09-20 18:47 ` Odd block highlighting [emacs-25 branch build] (Was: .. master build]) Kaushal Modi
2016-09-20 19:35 ` Odd block highlighting [master build] John Mastro
2016-09-20 19:44   ` Noam Postavsky
2016-09-20 19:50     ` Kaushal Modi
2016-09-20 20:06       ` Kaushal Modi
2016-09-20 20:10         ` Kaushal Modi
2016-09-20 20:53           ` Kaushal Modi
2016-09-20 21:48             ` Noam Postavsky [this message]
2016-09-20 20:49         ` John Mastro
2016-09-20 20:58           ` Kaushal Modi
2016-09-20 19:45   ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM-tV-9fPerHKwwnWWPuzBT6zkaZekFLKcp1j=GEto74e8BgwQ@mail.gmail.com' \
    --to=npostavs@users.sourceforge.net \
    --cc=emacs-devel@gnu.org \
    --cc=john.b.mastro@gmail.com \
    --cc=kaushal.modi@gmail.com \
    --cc=wsnyder@wsnyder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).