From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: current-active-maps doesn't look at emulation-mode-map-alists, why? Date: Mon, 26 Dec 2016 15:50:59 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1482785504 12704 195.159.176.226 (26 Dec 2016 20:51:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Dec 2016 20:51:44 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 26 21:51:41 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLcF4-00023V-11 for ged-emacs-devel@m.gmane.org; Mon, 26 Dec 2016 21:51:34 +0100 Original-Received: from localhost ([::1]:51676 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLcF8-0003CM-UV for ged-emacs-devel@m.gmane.org; Mon, 26 Dec 2016 15:51:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLcEZ-0003CG-6E for emacs-devel@gnu.org; Mon, 26 Dec 2016 15:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLcEY-0007kL-95 for emacs-devel@gnu.org; Mon, 26 Dec 2016 15:51:03 -0500 Original-Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:33520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cLcEY-0007jz-4M for emacs-devel@gnu.org; Mon, 26 Dec 2016 15:51:02 -0500 Original-Received: by mail-oi0-x233.google.com with SMTP id 128so136461998oig.0 for ; Mon, 26 Dec 2016 12:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Bhhlc6H+Y2OAB2ybvBFDuJG6wEdUVcTvg8/V88QUoGc=; b=TaWcp8qsCe6a8QOLQLbj4OyoIeT4t3Li3gOW19jvr8tU45fWZteCx6WbUfui43QzdR /35GmQboZ3d8W1x4vE8RZFdaaX45FojeGnbpeJGDe6cuRG/RBJsiikE5HZs1Fh79xR22 aDt5dF4XdtezAMHp7zQnfdecryu0z+PrhucEfEkLdkNePmgDRHJsSr1JlY6uNsceK0y4 XL45jt4gUudXjoVI95DeD+j+c2xTsxaerDQJFPLCtPUnbMIMCGZ4S+hbWKgK431f6xLF 4Posfh8IAK1M58dIFmIxaCnMOAP4WqoDdkjZTTDxndlIPKQ/uP1U0ChGouwloLVL1v0l rWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Bhhlc6H+Y2OAB2ybvBFDuJG6wEdUVcTvg8/V88QUoGc=; b=ZZHz9R0Hiz4ICcmRa3r0x5eOkuRL+3bGy9dpFeydjWUKBpvu4feFZiZuRtwpnRs8zT 42UXaQDlowJ6+n+/vysSGEEA2FkhTasnzfZ0NbEbC+PXi7cNolC0i9p4Ckb07wK0MG+B QCcYp9/N5WLgwK0ZG7MQL2Jk0Ha2gk9TT+4ptwjEcsBT2Bq47y7ntreMurrrwfFvquDB Tfs/AjC8TmLsCQCtf2J7OuFKkuhE6NVOY3I5COQdm5itOjlsN4QCQlpZUKLMBTNL/xAJ kt6tNaSw1o+F+cBAqJOkpXghJEP2g3XcCfO2fHpnbu/wMcNF8tq12S72KXSXARNTQjst vxaA== X-Gm-Message-State: AIkVDXK2uqzaJGvKMoaQ+whU6i421Yhe97KPzvPzGvvOAbvtK2BM0fFsYjLTcjLB2H/DJlo6KtGkNlTPxTanBA== X-Received: by 10.157.18.181 with SMTP id g50mr15224558otg.274.1482785459925; Mon, 26 Dec 2016 12:50:59 -0800 (PST) Original-Received: by 10.157.45.104 with HTTP; Mon, 26 Dec 2016 12:50:59 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: tK2_-dUopUp8s4N99BG4XLtFxC4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210824 Archived-At: On Fri, Dec 23, 2016 at 7:56 PM, Stefan Monnier wrote: >> Any reason why current-active-maps doesn't return keymaps from >> emulation-mode-map-alists? > > The most likely explanation is that this is a bug introduced when > emulation-mode-map-alists was added. > > The intention was really to make all code that uses the active keymaps > (such as read-key-sequence or the computation of menubars and toolbars) > get it from current-active-maps, but this never happened, so we still > have that code duplication. > read-key-sequence does use current-active-maps, not sure about menubars and toolbars (what code is that?) Fread_key_sequence return read_key_sequence_vs (prompt, continue_echo, dont_downcase_last, read_key_sequence_vs i = read_key_sequence (keybuf, ARRAYELTS (keybuf), read_key_sequence current_binding = active_maps (first_event); active_maps return Fcons (Qkeymap, Fcurrent_active_maps (Qt, position));