From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: current-active-maps doesn't look at emulation-mode-map-alists, why?
Date: Mon, 26 Dec 2016 15:50:59 -0500 [thread overview]
Message-ID: <CAM-tV-9PUxohC7+230vmYA2BbcC9niaqR8ks3mQBB0e=NC7i-g@mail.gmail.com> (raw)
In-Reply-To: <jwvk2aqb10j.fsf-monnier+gmane.emacs.devel@gnu.org>
On Fri, Dec 23, 2016 at 7:56 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> Any reason why current-active-maps doesn't return keymaps from
>> emulation-mode-map-alists?
>
> The most likely explanation is that this is a bug introduced when
> emulation-mode-map-alists was added.
>
> The intention was really to make all code that uses the active keymaps
> (such as read-key-sequence or the computation of menubars and toolbars)
> get it from current-active-maps, but this never happened, so we still
> have that code duplication.
>
read-key-sequence does use current-active-maps, not sure about
menubars and toolbars (what code is that?)
Fread_key_sequence
return read_key_sequence_vs (prompt, continue_echo, dont_downcase_last,
read_key_sequence_vs
i = read_key_sequence (keybuf, ARRAYELTS (keybuf),
read_key_sequence
current_binding = active_maps (first_event);
active_maps
return Fcons (Qkeymap, Fcurrent_active_maps (Qt, position));
next prev parent reply other threads:[~2016-12-26 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 4:02 current-active-maps doesn't look at emulation-mode-map-alists, why? Noam Postavsky
2016-12-24 0:56 ` Stefan Monnier
2016-12-26 20:50 ` Noam Postavsky [this message]
2016-12-27 1:50 ` Stefan Monnier
2016-12-27 3:04 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-9PUxohC7+230vmYA2BbcC9niaqR8ks3mQBB0e=NC7i-g@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).