From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: How to block tests on hydra
Date: Tue, 11 Jul 2017 07:45:27 -0400 [thread overview]
Message-ID: <CAM-tV-9H4O+dTXKWf4ogZawR8=7qtOhvVyEavw4CiVDJBviJrw@mail.gmail.com> (raw)
In-Reply-To: <877ezffnhv.fsf@detlef>
On Tue, Jul 11, 2017 at 3:20 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
>>
>> I'm surprised it does anything at all actually, isn't the (add-to-list
>> 'buffers ...) call a bug? Should be using `push' I think.
>>
>> - (add-to-list 'buffers (generate-new-buffer "foo")))
>> + (push (generate-new-buffer "foo") buffers))
>
> Why that? `add-to-list' is as good as `push' in this case. I haven't seen a
> problem with that. If you run in edebug, you'll see that `buffers' keeps
> all process buffers.
But you have lexical-binding:t set at the top of the file, and
`buffer' is a let-bound variable, whereas `add-to-list' operates on
dynamic variables. Hmm, looking at the disassembly it seems that
add-to-list's compiler macro fixed up the problem, although I thought
it should give a compile warning in this situation.
>
>> I noticed you added a with-timeout on that test, but it doesn't seem
>> to be working.
>
> The timeout is a self-defense. And it doesn't trigger at least for me,
> because (I believe) the test case is working properly now, and finishes
> in time.
What about this one:
http://hydra.nixos.org/eval/1373949
https://nix-cache.s3.amazonaws.com/log/v7ndmrhdhjw76v9mzghjyijnsmw2npl8-emacs-coverage-unknown.drv
>
>> By the way, I hit the "`tramp-test36-asynchronous-requests' timed out"
>> message when running locally in an -O0 build, although it succeeds
>> with an -O2 build. Maybe I just have a weak CPU.
>
> How does it make a difference? Is an asynchronous process to be intended
> to run in another thread, on another processor?
I don't know why it makes a difference.
next prev parent reply other threads:[~2017-07-11 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 11:48 How to block tests on hydra Michael Albinus
2017-07-11 3:44 ` Noam Postavsky
2017-07-11 7:20 ` Michael Albinus
2017-07-11 11:45 ` Noam Postavsky [this message]
2017-07-12 12:54 ` Michael Albinus
2017-07-14 1:30 ` Noam Postavsky
2017-07-14 8:58 ` Michael Albinus
2017-07-15 3:07 ` Noam Postavsky
2017-07-15 7:30 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-9H4O+dTXKWf4ogZawR8=7qtOhvVyEavw4CiVDJBviJrw@mail.gmail.com' \
--to=npostavs@users.sourceforge.net \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).