From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation Date: Thu, 4 Jan 2018 08:22:12 -0500 Message-ID: References: <87wp0yhsgu.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1515072062 8471 195.159.176.226 (4 Jan 2018 13:21:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 4 Jan 2018 13:21:02 +0000 (UTC) Cc: Emacs developers To: Robert Cochran Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 04 14:20:57 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX5S5-0001rT-1K for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 14:20:57 +0100 Original-Received: from localhost ([::1]:60367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX5U4-0002tx-7o for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 08:23:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX5TO-0002rS-5F for emacs-devel@gnu.org; Thu, 04 Jan 2018 08:22:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX5TJ-0000QH-Mv for emacs-devel@gnu.org; Thu, 04 Jan 2018 08:22:18 -0500 Original-Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:34045) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eX5TJ-0000Op-F3 for emacs-devel@gnu.org; Thu, 04 Jan 2018 08:22:13 -0500 Original-Received: by mail-wr0-x22d.google.com with SMTP id 36so1470838wrh.1 for ; Thu, 04 Jan 2018 05:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=mUUPVZZNLxMx96gVrIhyK8n6HzMmwV8zJ1hutx+FXrI=; b=IkPBC/Vv3b9SqARLl2K4ltwTK4Q7/+KemLuy5gHgbMOsJ5nwHlADa5cmIW1k0Wvecj 4VlSlDVXLMc4Lbz1Bl98fr4W6feu8XuHXURXOIWL6CO10kWjX1J/LKAI3vsNvdeqEejn BZJ6ZmjD//YNPa0DytBuOQ3DGX4Yogcg3PWTbqLULTtCGd3clR8es76l3/6pX1pwJ9rG dkZj0ncfoZcam59cndMCS38ucoe5M3PCURS4BymaBDel1SAlwjbOroNNP6a0ogbEcWqg o920E4/9NKC9NOR5gF0O+tx4U+2Ko6W56wdp3hMdpNBXl03trb+IeLwrmZwda0KHdDll LyTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=mUUPVZZNLxMx96gVrIhyK8n6HzMmwV8zJ1hutx+FXrI=; b=qSOesunDhUGPY0xxhNrYO4ne3oRbCx4/lCGtXJpFwzVX0zcAOJnh8sHpD4exbUjCVe MGViDRGIuWlGC7mrfZf/e80XwysDIGQWqCLTukq+7WoaOEijvt7jebueyAMZOSVski4Y 7GlzAQDHsKAq2LdoqQf2a+9f1ZGzrv9PfRnngMIaaQ2FLe+SPDWbPTarnssWEe54cj0J 3XkDrroFw2XG8FAdjkLcArvNx4bNDfIqrt0Wl5UUIjZ7y2LXJTGNndY5P3hrwxUSKlSG o/Y4U3pfPVlYj2BpEGJhuDXwBhLYDahNFwzPyIJ5LE1IPtW2pONBapgFm9P+f772jjO2 sQkQ== X-Gm-Message-State: AKGB3mILrWnlDkapWrXQT8g6WkqeXZfB467eMKwwNwAgLcoIJS3l5VTw 4R4ifqb1CrUsTMq3s05++K5M1M7YLz0ZGy4SU57l4w== X-Google-Smtp-Source: ACJfBouUMo9U4KD7EZBPCQ41gGiSv4GkpX42Rm/Q8jradzbsVlIkg2NNE+mbGMOcs2gXjyPmJq1BNkS/LFqMJ88yvGc= X-Received: by 10.223.187.7 with SMTP id r7mr4919853wrg.233.1515072132433; Thu, 04 Jan 2018 05:22:12 -0800 (PST) Original-Received: by 10.223.145.129 with HTTP; Thu, 4 Jan 2018 05:22:12 -0800 (PST) In-Reply-To: <87wp0yhsgu.fsf@cochranmail.com> X-Google-Sender-Auth: GGciAut0SNxhGTwtsoSn47Kc9jY X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221589 Archived-At: On Thu, Jan 4, 2018 at 4:40 AM, Robert Cochran wrote: > Attached is a patch that adds the variable `byte-compile-error-on-warn' > to the safe variable list temporarily during calls to > `byte-compile-file`, so that individual files can easily and simply > include "byte-compile-error-on-warn: t" in their file local variables. Wouldn't it be simpler and clearer to make it permanently safe? (PS you can use #'booleanp instead of listing t and nil). > For example, something that is bothering me right now > is that there are quite a few 'foo is obsolete' warnings during the byte > compilation portion of the build phase. Enabling error on warning means > that trying to byte compile files that reference stale > functions/variables/what have you will fail, prompting patches that > obsolete Lisp objects to also fix usage of it in the core with the > appropriate recommended replacement. Solving Bug#4837 would be helpful for this, as currently there is no practical way to fix/suppress the obsolete warnings in the code that remains to support the obsolete option. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=4837