From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: shr-copy-url: arg misnamed? Date: Sun, 23 Sep 2018 16:04:40 -0400 Message-ID: References: <20180922161218.BA963C20207@raman-glaptop.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1537733015 7564 195.159.176.226 (23 Sep 2018 20:03:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Sep 2018 20:03:35 +0000 (UTC) Cc: Emacs developers To: raman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 23 22:03:30 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4AbI-0001r5-W3 for ged-emacs-devel@m.gmane.org; Sun, 23 Sep 2018 22:03:29 +0200 Original-Received: from localhost ([::1]:42278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4AdP-0002Ib-9O for ged-emacs-devel@m.gmane.org; Sun, 23 Sep 2018 16:05:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4Aci-0002IT-LN for emacs-devel@gnu.org; Sun, 23 Sep 2018 16:04:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4Ach-0002ag-De for emacs-devel@gnu.org; Sun, 23 Sep 2018 16:04:56 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:37260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4Ach-0002Zy-7j for emacs-devel@gnu.org; Sun, 23 Sep 2018 16:04:55 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id n1-v6so2766910oic.4 for ; Sun, 23 Sep 2018 13:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UAGmIgAtbmBGY3PhmoeP7gradmu5ppaumbB4WhjRuhk=; b=va9Z1Vukvr/LOSIod8VIAxL7IEwTu41vu6+Lj1dAo9GWqPnnes9VrnmLJFZwt5W/CB BOo6YbpTpnD8N6CNxfpXCepeUnunxzUiI17W7XjyHC0Ay8rY3TPhVjQoN0gIYAsn7UoE 8CQy01vufuqJd0Freeh7iQfAuiodv3aBZoMxVoVMGR5BfILLTrAbFZiwvhTgnvUWOBCM doqQ/k8tFSkn2I0vjVR2C8V5qgSKNWcLERXe5/MA7/sVBSbsTt0D5SvK8E7fThzAKbk/ LFtppMX2r+JB7k2Bz/Z+B7wj+Cv5cFnYggK6o9TIW7KFTv4cKbMPTPK/AepFP1ohRoC4 LCIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UAGmIgAtbmBGY3PhmoeP7gradmu5ppaumbB4WhjRuhk=; b=iVlscmbpr29jfB7tm67lDo9i+hPsrufS7tN3rWWV8k0+6NEY/pyV6SWNqxo3PmEqqx jkpDcbpvuiblzlVAUrD2Q0xT947fYzFp5F+Q4HciQotZy3YYFRstSM2AykTL3IhAeIVX HWf3qvfeFv0y0ICUya7Grh7TAYQHvGzapxl8jS7B29fjAaKTVvCh7HvKiC1LehVuB0qj mxYi5qFlRkA6P0vjo6V0hPBfF6OjzGnmN+4NTK0sz1HNFnV6yi7FMQb9VG1WwD63W8V/ DBAkLMCfSuIUNh+Gd36cEqiv6jEpuJDJEncJ4KU1YKcfaJpUjzmOvsyI5sOhmedJuHY0 wTHA== X-Gm-Message-State: APzg51Cw0R6QHkRWhuKfnJ+STLyvyZd1rjy6e+MuEuyIoB5sFGpdfVwt HkWE39JpTzV3feMxi3SRBvAfc8OTDakm0vx4nIg= X-Google-Smtp-Source: ANB0VdZC9ZCaqIBDqA7DLKJHxSrrviuHJVzIu6AR05Pva4Lx1UvOtFseoEwFgH9SY9pgR3Y33GFO3BI/Ld3QSEUH3b4= X-Received: by 2002:aca:3003:: with SMTP id w3-v6mr4019185oiw.231.1537733094425; Sun, 23 Sep 2018 13:04:54 -0700 (PDT) In-Reply-To: <20180922161218.BA963C20207@raman-glaptop.localdomain> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230009 Archived-At: On Sat, 22 Sep 2018 at 12:22, T.V Raman wrote: > > Should the arg in this function be renamed? > > The name "url" is confusing, and is likely being shadowed Not sure what you mean by shadowed, but the docstring has a copy-paste mistake: it should say "with a prefix argument" instead of referencing IMAGE-URL (which is an arg of shr-url-at-point).