From: Noam Postavsky <npostavs@gmail.com>
To: Robert Cochran <robert+Emacs@cochranmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/
Date: Wed, 21 Feb 2018 22:24:04 -0500 [thread overview]
Message-ID: <CAM-tV-9+V5x0A3_kp=_31OLCnV1qDFsNaXAvM0gZXou4gvfkdw@mail.gmail.com> (raw)
In-Reply-To: <87h8q9n4dt.fsf@cochranmail.com>
On Wed, Feb 21, 2018 at 9:29 PM, Robert Cochran
<robert+Emacs@cochranmail.com> wrote:
>> If you instead set byte-compile-error-on-warn to t by default (e.g.,
>> on the command line) and just set it to nil in files which trigger a
>> warning, would the patch be bigger or [smaller]?
>
> According to my blacklist and whitelist files, 179 warning files vs 1319
> non-warning files, so significantly smaller it seems. I'll look into
> modifying the Makefile.in to accommodate this.
Marking warning files also has the advantage of avoiding problems for
files which are distributed outside of Emacs.
For lisp/cedet/ files we should probably just set it to nil in a
.dir-locals file, since there's not much point in fixing up warnings
while the cedet merge problem remains unresolved.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28878
>> By the way, I think it would be better to set it in the local
>> variables list at the end of the file, rather than in the first line.
>> For lexical-binding it's required to put it there for technical
>> reasons, but I think those don't apply to byte-compile-error-on-warn,
>> and that first line can get a bit crowded.
>
> I generated this mechanically via add-file-local-variable-prop-line in
> an Emacs Lisp batch script. Is there a mechanism by which I can use
> a-f-l-v-p-l or some other function to put it at the bottom?
add-file-local-variable adds to the bottom, I believe.
prev parent reply other threads:[~2018-02-22 3:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:30 [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Robert Cochran
2018-02-21 18:42 ` Eli Zaretskii
2018-02-22 2:51 ` Robert Cochran
2018-02-22 6:56 ` Eli Zaretskii
2018-02-21 19:24 ` Stefan Monnier
2018-02-22 3:05 ` Robert Cochran
2018-02-22 5:24 ` Stefan Monnier
2018-02-22 7:18 ` Eli Zaretskii
2018-02-23 9:47 ` Richard Stallman
2018-02-24 11:08 ` Eli Zaretskii
2018-02-24 23:33 ` Richard Stallman
2018-02-25 3:33 ` Eli Zaretskii
2018-02-25 13:13 ` Stefan Monnier
2018-02-25 15:33 ` Eli Zaretskii
2018-02-22 7:13 ` Eli Zaretskii
2018-02-21 19:26 ` Noam Postavsky
2018-02-22 2:29 ` Robert Cochran
2018-02-22 3:24 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-9+V5x0A3_kp=_31OLCnV1qDFsNaXAvM0gZXou4gvfkdw@mail.gmail.com' \
--to=npostavs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=robert+Emacs@cochranmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).