From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: moving some indentation tests Date: Fri, 7 Apr 2017 12:06:08 -0400 Message-ID: References: <878tnj2lap.fsf@tromey.com> <874ly6ft50.fsf@russet.org.uk> <87y3vhd9ud.fsf@russet.org.uk> <874ly5cuob.fsf@russet.org.uk> <877f2ww70m.fsf@russet.org.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1491581225 3869 195.159.176.226 (7 Apr 2017 16:07:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Apr 2017 16:07:05 +0000 (UTC) Cc: Tom Tromey , Emacs discussions To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 07 18:07:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwWPW-0008K9-Dz for ged-emacs-devel@m.gmane.org; Fri, 07 Apr 2017 18:06:54 +0200 Original-Received: from localhost ([::1]:51735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwWPc-0001wX-D7 for ged-emacs-devel@m.gmane.org; Fri, 07 Apr 2017 12:07:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwWOp-0001uw-4i for emacs-devel@gnu.org; Fri, 07 Apr 2017 12:06:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwWOo-0007Sg-3Y for emacs-devel@gnu.org; Fri, 07 Apr 2017 12:06:11 -0400 Original-Received: from mail-oi0-x232.google.com ([2607:f8b0:4003:c06::232]:35408) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwWOn-0007SS-WE for emacs-devel@gnu.org; Fri, 07 Apr 2017 12:06:10 -0400 Original-Received: by mail-oi0-x232.google.com with SMTP id f193so90943078oib.2 for ; Fri, 07 Apr 2017 09:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=e2OTbwSNlFa/v3BsGexaPSlEgCMnnYGbs5EiQWzai+s=; b=k2G2QWpHnFpxJK77foc/P/4+60iDJExC2H3GFJB7PR0pLklkgEO238oncAZjxV9KAm 7HlhbBxIk4gjPTbDgccT/kD95K9gxd6lgokdZoJNNAK65NbwEJ5jgwDmE5XfYP0lpeEe K0gnKhCTIqO4+YPl0no3msnSxgEDFVO/lVHxBLFQAJuTPqAnwvzzLO5hcu7fFazpY7qO w59XhJlcfIWYr4BG1YdTJu1xhgSncvZxjuihlYb6e35hmFXSV+AYK1lKpsj2eGcN7/G5 rn4bebE5+R7rllledDHFw+pi1SRK4Nh6tDD5/1FHksQnVs4nOw7lC2FlGIV/DqVOivk0 atxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=e2OTbwSNlFa/v3BsGexaPSlEgCMnnYGbs5EiQWzai+s=; b=WPzMzzT2bkN2OEe9kooNQO/R1rjuLCT6FQahBItr3TUX6foACoHwXsLWNw0hRCdbES alxw1X8QnykIj/gO1MTRoOG2f3/MvF5l0rU/Ky2fSGg9gvv2r5ks9ZjhowV7hz3v34Fi CmUL8QXZxJxYdU2ZZSTspBC6KsVkErTk9r39E7BcBita83vskrFfDejfltqj6i2tJHMw V2FbY8W2MqM5zz0A7kHLpInf1GfsR+aR4GecnY+J1kCKNwm9t/jdwuL3kKZ04KJpfzi8 6qM5FPgsqEk8Up57tluLOZjrkqn449hV7268oYhUMCMWoA5mVhubDsH2buX28psXFE1r Nc2Q== X-Gm-Message-State: AFeK/H31wV054t3Ur6OthJiFCAtAVW66kp9ZZRVgylpAy5dWzCyxoLPWhO3CledXWvoolRno3ivcz2xgWvRg1w== X-Received: by 10.202.89.139 with SMTP id n133mr19966907oib.70.1491581169159; Fri, 07 Apr 2017 09:06:09 -0700 (PDT) Original-Received: by 10.157.80.133 with HTTP; Fri, 7 Apr 2017 09:06:08 -0700 (PDT) In-Reply-To: <877f2ww70m.fsf@russet.org.uk> X-Google-Sender-Auth: xBEayX0WKkFNKaiIFtDGYjNXcXg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213759 Archived-At: On Fri, Apr 7, 2017 at 11:51 AM, Phillip Lord wrote: > Noam Postavsky writes: >> Ah, because lisp-indent-line doesn't check the parse context. >> `indent-sexp' does the right thing, if called outside the string (and >> also inside since #21343 was fixed). >> >> I believe my patches at >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25122#77 will fix this >> for `indent-region' (since I happened to copy the syntax-ppss fix from >> #21343). Probably `lisp-indent-line' should also use syntax-ppss to >> get the correct parse context. > > So, in this case, assess is working? lisp-indent-line is, effectively, > broken? I think both assess and lisp-indent-line are broken for this case, in different ways. js-indent-line seems to handle this correctly though. So you should be able to test assess with js-mode.