From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: pretty printing frames from *Backtrace* Date: Mon, 21 Nov 2016 18:31:12 -0500 Message-ID: References: <877f80i1sd.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1479771083 25295 195.159.176.226 (21 Nov 2016 23:31:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Nov 2016 23:31:23 +0000 (UTC) Cc: Emacs Development To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 22 00:31:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8y3S-0005Av-Eo for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2016 00:31:18 +0100 Original-Received: from localhost ([::1]:52245 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8y3V-0003Qp-Ns for ged-emacs-devel@m.gmane.org; Mon, 21 Nov 2016 18:31:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8y3Q-0003Qa-1I for emacs-devel@gnu.org; Mon, 21 Nov 2016 18:31:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8y3P-0007Zp-5c for emacs-devel@gnu.org; Mon, 21 Nov 2016 18:31:16 -0500 Original-Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]:36657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8y3O-0007Yl-Vp for emacs-devel@gnu.org; Mon, 21 Nov 2016 18:31:15 -0500 Original-Received: by mail-oi0-x22e.google.com with SMTP id v84so1187641oie.3 for ; Mon, 21 Nov 2016 15:31:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=cLldf4zy0cx0upX5XIcHWc8jKB6w4Hws6BgHNW+lcC8=; b=cuIzODDZ5WrXESztffXPS3HKhV4I74JEB4wNAN3x2Td3cXhfErcKia71trGQ8FDptz kU/68K0MJ22B1u5KPLwp6aLgoufUeVhWdFio2laOOqT2djYJlyxkZG4Pin2P85bL32CZ cKwvqGHPn1M3U+6mJ1XpkA1fAnGRF7IEPc0MwMPkb2nK+VNKxPcSM/SGHoYYmNHpPqr6 OCt+Tc24L3uzNxbJnzLuVI0HqfiU1FiOyx2JM37MPl5HR0eXUEB8OyWmJFcyMorzeVKE r9GqdY7chXHYQkIKQN5UjCm9cVXhjbdXDrUsWIo1yfU/hyOKT+OcBDeWijrjhLpcbYSj eaMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=cLldf4zy0cx0upX5XIcHWc8jKB6w4Hws6BgHNW+lcC8=; b=VRk/EDqr/9TKOkU9r1pe4Nu6K8yoVLu98c/+8+LrNmDJg+9w8diaZ5/yNCfkOV5Kq7 5xbdN5ChVYXrd0VNAdAWDwa+CjXBgK/N9FWPVt9znUcpmGHp+utMNXsg5Wcwcj7jBqXP 6d9Lsn1bvGivM/yajCgFvCoHSOGVMjn1IouAGiFixMc2JL6xRa0K2TdV5p3m5zPFTWy6 bGkhwXs1y7FdWaANcNK/qoOT3WkMA+RvFWPoVfKgwf1zi86DVBsqNHEoovfZ9o5dz437 5s6ESXDqBlNdvcHeptDM3eS/gG5VD9h36kNb3Y8q/lftv6zqYuRiQJJRHDBjkICKFvXP JQAA== X-Gm-Message-State: AKaTC01XO7m3jwAJRbKzNMNKfM1UvzTqmhBtChoqSHzm4k6yA/QGX8xNLn2GfPeFlD8flqbO+kgdZZ+86EPcBg== X-Received: by 10.202.85.77 with SMTP id j74mr7026714oib.108.1479771073310; Mon, 21 Nov 2016 15:31:13 -0800 (PST) Original-Received: by 10.157.4.67 with HTTP; Mon, 21 Nov 2016 15:31:12 -0800 (PST) In-Reply-To: <877f80i1sd.fsf@web.de> X-Google-Sender-Auth: XaIocZEWBGN1HvOnFKJf8AdPOKg X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209533 Archived-At: On Fri, Nov 18, 2016 at 10:30 PM, Michael Heerdegen wrote: > >> I think it would be easier to integrate directly into the debugger, it >> would probably save the trouble of cumbersome frame counting. > > Doesn't the debugger already do frame counting from Lisp - see > `debugger-frame-number' (AFAICT marking frames for debugger-reentry is > based on this)? FWIW I've changed my code to use this function instead > of reinventing the wheel. Ah, if you can reuse the debugger's counting that's okay. I still think this would be better as an integrated feature of the debugger though. Currently I switch to edebug as soon as I have an idea of which function to instrument because of how hard it is to read backtraces, having this feature really looks like a bare minimum to me, not an addon.