From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: master 4b39b74: python.el: don't syntax-propertize single/double quoted strings Date: Wed, 10 Apr 2019 19:59:06 -0400 Message-ID: References: <20190409190826.19114.45574@vcs0.savannah.gnu.org> <20190409190828.20AE320E55@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95224"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 11 01:59:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hEN8G-000Ob6-3m for ged-emacs-devel@m.gmane.org; Thu, 11 Apr 2019 01:59:56 +0200 Original-Received: from localhost ([127.0.0.1]:39342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEN8F-00027l-0i for ged-emacs-devel@m.gmane.org; Wed, 10 Apr 2019 19:59:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEN7f-00027g-Ou for emacs-devel@gnu.org; Wed, 10 Apr 2019 19:59:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEN7e-0004G4-Nx for emacs-devel@gnu.org; Wed, 10 Apr 2019 19:59:19 -0400 Original-Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:38124) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEN7e-0004F6-F7 for emacs-devel@gnu.org; Wed, 10 Apr 2019 19:59:18 -0400 Original-Received: by mail-ot1-x336.google.com with SMTP id e80so3610103ote.5 for ; Wed, 10 Apr 2019 16:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=m86bE0twoX77D+l3GT8Vb93sLArU3sR1tqrHb9la8bk=; b=SZxN8+VQf0FjeqG+CY1HVMkXBI+zHJ8nyavGnH56gpBk76PSm77NkUhDtxurLh7JR3 cquh5h8ZOjWUFF+reXVnOMfKCvyi0GtOE7rXyyQ9xxMHcrdGOcE4wxW9oUHui8BMmljF eMGYutzssVQpzDM32D0fwjA1Uw4CB4jpOCg5Z0zl2NQmd3T2gFc2l7i5pCsebBsAEmN8 puYlUWJdj/yJK4QvDGs553/YO3NB5+2+lKDFl3UFbAPmrI5wbcClllKhDUlWNUuOoE8A q1rzMnXi2/3V6F2cA6mk9kGBKliA8wpDqw7phImJxPoQYEC5+mcB3O0erfS1mfMwhzIN 2Xsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m86bE0twoX77D+l3GT8Vb93sLArU3sR1tqrHb9la8bk=; b=FK72NtIyvzRvvBzOFdpXLTEUwgldiY2ybW/ZY7+U97ZsUYF5UXQVZqYwaVOkTGjSlI zHFH/og0ifJM8LejpL947wPnt5ziORfOUfkMuxWvlomIqB9159Y+Qt0O97Y0ONOmBs3z AsNG7X8BkBMNyjQAO3DBHlp03CLlP0tpq1a9wtJ68m7pN2gHOWotBzeW/Jp62UJhFglH yNL7utaLR664bfKFrFF453BeKeHLA38tCYkikQ5z9/FPdV+vKY5EzZH1MZGz2vX0bByY 9dnwIeHhXqhzeC5V9UHD+OsQjtwTklZSq/xQrIp60xAcj4x6CqYfWCLPor9UwLu2++4v cgfQ== X-Gm-Message-State: APjAAAWdvaWsov2QfVZ1L5PxcPBhE/nJyidVaxD/s63LQY0F30y4y1HQ Ul6sb79dxMhjKxEjywPEQGDAgR5Hzz7qdX+SrE0= X-Google-Smtp-Source: APXvYqxrASRmVgG9XItdbh8GQ2tq3a5byvw0Cqnep8oqFGvd0c9e5zOAnAxK99FOtefVP4CC6Q+V+dSPphpuJU4Yi6g= X-Received: by 2002:a9d:7749:: with SMTP id t9mr30464509otl.229.1554940757620; Wed, 10 Apr 2019 16:59:17 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::336 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235259 Archived-At: On Wed, 10 Apr 2019 at 11:18, Cl=C3=A9ment Pit-Claudel wrote: > >> This causes python-tests--python-nav-end-of-statement--infloop to fail= . > > Hmm... I can't find a better way than to disable it, sorry. > But that test was added to prevent regression of an actual bug, right? > Did your commit reintroduce the bug? If so, disabling the test doesn't so= und ideal=E2=80=A6 I think the related report is Bug#30964, but there was never a clear reproducer for it. The commit that introduced the test is [1: 4fbd330fae], whose commit message says: "[...] Unfortunately it is impossible to reproduce without manually destroying the syntactic information in the Python buffer, but it has been observed in practice [...]". [1: 4fbd330fae]: 2017-03-23 23:05:19 +0100 Protect against an infloop in python-mode https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D4fbd330fae54a9c4= 5d4a717127aa86d75e9938d5