From: Noam Postavsky <npostavs@gmail.com>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 4b39b74: python.el: don't syntax-propertize single/double quoted strings
Date: Wed, 10 Apr 2019 19:59:06 -0400 [thread overview]
Message-ID: <CAM-tV-8PfZ=18CSzqgyAO1nCytQ7y_jGYZLpaT2SxqLDtpfjbA@mail.gmail.com> (raw)
In-Reply-To: <ade648b2-581b-c170-4056-1712c2d4ba44@gmail.com>
On Wed, 10 Apr 2019 at 11:18, Clément Pit-Claudel <cpitclaudel@gmail.com> wrote:
> >> This causes python-tests--python-nav-end-of-statement--infloop to fail.
> > Hmm... I can't find a better way than to disable it, sorry.
> But that test was added to prevent regression of an actual bug, right?
> Did your commit reintroduce the bug? If so, disabling the test doesn't sound ideal…
I think the related report is Bug#30964, but there was never a clear
reproducer for it. The commit that introduced the test is [1: 4fbd330fae],
whose commit message says: "[...] Unfortunately it is
impossible to reproduce without manually destroying the syntactic
information in the Python buffer, but it has been observed in
practice [...]".
[1: 4fbd330fae]: 2017-03-23 23:05:19 +0100
Protect against an infloop in python-mode
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fbd330fae54a9c45d4a717127aa86d75e9938d5
next prev parent reply other threads:[~2019-04-10 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190409190826.19114.45574@vcs0.savannah.gnu.org>
[not found] ` <20190409190828.20AE320E55@vcs0.savannah.gnu.org>
2019-04-10 3:23 ` master 4b39b74: python.el: don't syntax-propertize single/double quoted strings Glenn Morris
2019-04-10 14:41 ` Stefan Monnier
2019-04-10 15:00 ` Clément Pit-Claudel
2019-04-10 16:23 ` Stefan Monnier
2019-04-10 17:28 ` Clément Pit-Claudel
2019-04-10 23:59 ` Noam Postavsky [this message]
2019-04-26 8:12 ` Andreas Röhler
2019-04-26 12:22 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-8PfZ=18CSzqgyAO1nCytQ7y_jGYZLpaT2SxqLDtpfjbA@mail.gmail.com' \
--to=npostavs@gmail.com \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).