unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: "Fabián E. Gallina" <fgallina@gnu.org>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>,
	"Emacs developers" <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633)
Date: Thu, 1 Mar 2018 22:15:12 -0500	[thread overview]
Message-ID: <CAM-tV-8JzfTcLzioB8TXF86-BmeD1fF7mdztmu4zKB7vECF1MQ@mail.gmail.com> (raw)
In-Reply-To: <87po4p5z0x.fsf@gmx.de>

On Wed, Feb 28, 2018 at 2:55 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
>>          (file-name (expand-file-name (file-local-name file-name)))
>>          (temp-file-name (when temp-file-name
>>                            (expand-file-name
>>                             (file-local-name temp-file-name)))))
>>
>> I don't understand how/why it makes sense to apply expand-file-name on
>> its return value.  Shouldn't this be
>>
>>          (file-name (file-local-name (expand-file-name file-name)))
>>          (temp-file-name (when temp-file-name
>>                            (file-local-name
>>                             (expand-file-name temp-file-name)))))
>>
>> ?
>
> Yes. If, for example, file-name is "/ssh:user@host:~/what/ever", the
> former forms might fail, because "~/what/ever" could be expanded
> differently on local and remote hosts.

Thanks, I fixed this and the other issues Stefan pointed out.

[1: 4a09341921]: 2018-03-01 22:07:21 -0500
  Fix issues turned up by previous python.el change
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4a0934192176fb8e372170f5f028edcf0f8cbdc3



      reply	other threads:[~2018-03-02  3:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180228012154.1636.19993@vcs0.savannah.gnu.org>
     [not found] ` <20180228012156.38869207B1@vcs0.savannah.gnu.org>
2018-02-28  2:03   ` [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633) Stefan Monnier
2018-02-28  3:33     ` Noam Postavsky
2018-02-28  5:10       ` Stefan Monnier
2018-02-28  7:55     ` Michael Albinus
2018-03-02  3:15       ` Noam Postavsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV-8JzfTcLzioB8TXF86-BmeD1fF7mdztmu4zKB7vECF1MQ@mail.gmail.com \
    --to=npostavs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=fgallina@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).